Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Market: Replace "trading fee" with "taker fee" and re-define "maker fee" to be independent #670

Closed
thinkloop opened this issue Jun 22, 2016 · 1 comment
Assignees
Milestone

Comments

@thinkloop
Copy link
Contributor

thinkloop commented Jun 22, 2016

Currently we have:

trading fee: % of total value of trade (ie 2%)
maker fee: % of trading fee (ie 50%)

We are simplifying this paradigm so that a taker fee and maker fee can be specified more independently of each other, and dropping the concept of trading fee from the ui. In the market creation process, the fee inputs should be:

taker fee: % of total trade value (ie 2%)
maker fee: % of total trade value but not higher that 50% of taker fee (ie 1%)

The only limitation is that the maker fee cannot exceed half of the taker fee. Ex: if taker fee is 3% maker fee can be between 0 and 1.5%.

These fees will also be passed into augurjs for the createMarket functionality, so this issue is dependent on this one: AugurProject/augur.js#85

And the related UI work: tinybike/augur-ui-react-components#36

@stephensprinkle-zz
Copy link
Contributor

PRs #675 + AURC #42 resolve this issue -- closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants