New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Volume #904
Comments
In the We need to write a migration script to regenerate this value from the trades table and either:
In the interest of ease for v1 I'd recommend the second approach. For v2 anything we store should be in on-chain / atto units. |
Sure let’s store it as ETH |
I haven't looked into this, but it seems you guys are reporting that my recent volume fix PR AugurProject/augur-node#777 is handling units improperly. Note that the fix for this will require a DB reset. [Edit: Alex suggested a fix migration which works] My PR expects that The fix can probably be entirely isolated to the pure function @nuevoalex if you explain the correct conversion, I'm happy to open a fix PR. |
It should be doable without a reset. We can just rebuild the volumes from the trades table in a migration |
Took a look at the code again and its actually a bit different than attoETH vs ETH. The values being passed to In particular this portion:
Will produce a value far too high since
Where the |
Fixes AugurProject/augur#904 and details in that ticket.
Fixes AugurProject/augur#904 and details in that ticket.
Volume has been broken for a few weeks, way too high, dunno why
The text was updated successfully, but these errors were encountered: