Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[BUG] Volume #904
We need to write a migration script to regenerate this value from the trades table and either:
In the interest of ease for v1 I'd recommend the second approach. For v2 anything we store should be in on-chain / atto units.
I haven't looked into this, but it seems you guys are reporting that my recent volume fix PR AugurProject/augur-node#777 is handling units improperly.
Note that the fix for this will require a DB reset. [Edit: Alex suggested a fix migration which works]
My PR expects that
The fix can probably be entirely isolated to the pure function
@nuevoalex if you explain the correct conversion, I'm happy to open a fix PR.
Took a look at the code again and its actually a bit different than attoETH vs ETH. The values being passed to
In particular this portion:
Will produce a value far too high since