React Js Testing HomeWork #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jw56578
reviewed
Jan 23, 2018
src/services/array-functions.js
Outdated
| //fnc will return true or false, if true return the item | ||
| //return null | ||
| export function find(theArray, fnc){ | ||
| let findArray = []; |
Contributor
There was a problem hiding this comment.
Look over this again. The instructions don't tell you to make an array or push to an array
Author
|
Ok will do
…On Jan 23, 2018 8:25 AM, "Jon Woo" ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/services/array-functions.js
<#40 (comment)>
:
> //return null
export function find(theArray, fnc){
+ let findArray = [];
Look over this again. The instructions don't tell you to make an array or
push to an array
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#40 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AXbLzb-VNLonjpcMbqCOcpkicwILFF1Wks5tNevYgaJpZM4Ro2Yo>
.
|
Author
|
Hey, Jon fixed the code. the find and filter are very similar and I
copied the code from the above line and forgot to change it, but it should
be good now
On Tue, Jan 23, 2018 at 10:29 AM, Christopher Jauregui <
chrisjay629@gmail.com> wrote:
… Ok will do
On Jan 23, 2018 8:25 AM, "Jon Woo" ***@***.***> wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In src/services/array-functions.js
> <#40 (comment)>
> :
>
> > //return null
> export function find(theArray, fnc){
> + let findArray = [];
>
> Look over this again. The instructions don't tell you to make an array or
> push to an array
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#40 (review)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AXbLzb-VNLonjpcMbqCOcpkicwILFF1Wks5tNevYgaJpZM4Ro2Yo>
> .
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.