Skip to content

Austin Wise
AustinWise

AustinWise commented on pull request dotnet/cli#1212
@AustinWise

@dotnet-bot Windows_NT Debug Build please

@AustinWise
AustinWise commented on pull request dotnet/cli#1212
@AustinWise

@brthor Odd, I don't understand why ProcessStartInfo.Enironment stopped working on just Windows. Do you have any ideas? 'ProcessStartInfo' does not…

AustinWise commented on pull request dotnet/cli#1212
@AustinWise

Since ANSI pass through is temporary, when I rebased I did not add the new parameter to ICommand. As an aside, during testing I discovered that Win…

@AustinWise
@AustinWise
AustinWise commented on pull request dotnet/cli#1212
@AustinWise

I rebased and it seems like #1364 has fixed the build problems. I tested out my changes the colors are still fixed.

@AustinWise
  • @piotrpMSFT 0863e02
    Merge pull request #1253 from dotnet/piotrpMSFT/dotnet-testConfiguration
  • @anurse 3673e5e
    Merge pull request #1254 from eerhardt/UpdateNetCore
  • 89 more commits »
@AustinWise
@AustinWise
Build does not work on Ubuntu because of System.CommandLine lacking a strong name
@AustinWise
@AustinWise
AustinWise commented on pull request dotnet/cli#1212
@AustinWise

I rebased onto the tip of 1.0.0 to fix the merge conflicts.

@AustinWise
AustinWise commented on pull request dotnet/cli#1212
@AustinWise

If #1240 get's merged first I'll rebase ontop of it and try it out. It does not look like it would cause any problem. Thanks for reviewing my changes!

AustinWise commented on pull request dotnet/cli#1231
@AustinWise

@dotnet-bot test this please It seems like package restore failed.

@AustinWise
  • @AustinWise 97ee6c6
    Fix color printing and verbosity.
AustinWise commented on pull request dotnet/cli#1212
@AustinWise

Oh, that's a good idea, I'll add that in.

@AustinWise
  • @AustinWise 7d1f99b
    Fix color printing and verbosity.
AustinWise commented on pull request dotnet/cli#1212
@AustinWise

I pushed a revision where I only set the environmental variable if output is being redirected to the Reporter, which knows how to handle the ANSI e…

@AustinWise
AustinWise commented on pull request dotnet/cli#1231
@AustinWise

I tried moving moving more of the help functions into the HelpCommand. This way the control flow is more consistently from Program to HelpCommand, …

@AustinWise
  • @AustinWise e3f5367
    PR feedback: move more of the help text into the help command.
AustinWise commented on pull request dotnet/cli#1231
@AustinWise

I push a new commit wherein I moved made 'help' be a command like any other. That seems cleaner than making Cli.Program pretend a help command exists.

@AustinWise
  • @AustinWise 3e2e1b8
    Respond to PR feedback: make help it's own method.
AustinWise commented on pull request dotnet/cli#1212
@AustinWise

I push a new commit that just applies the environmental variable to all children created with the Command class. I think this is the right place to…

@AustinWise
  • @AustinWise 531e9f3
    Fix color printing and verbosity.
@AustinWise
  • @AustinWise a2c8ed9
    Fix color printing and verbosity.
AustinWise commented on pull request dotnet/cli#1212
@AustinWise

Yeah, it does not seem a bit hacky. I think it would not be too hard to make all external external commands. Since all the commands use Command.Cre…

AustinWise commented on pull request dotnet/cli#1231
@AustinWise

I pushed a new commit that has this all moved to a separate method. Let me know if it looks better.

Something went wrong with that request. Please try again.