Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update logo svg #184

Merged
merged 6 commits into from Aug 6, 2018

Conversation

2 participants
@mymindstorm
Copy link
Member

mymindstorm commented Aug 3, 2018

Bringing it closer to the original. Not really sure how to add a stroke path without doubling up the opacity on the bottom shadow.

Docs for later: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/icons#SVG

mymindstorm added some commits Aug 3, 2018

@mymindstorm mymindstorm requested a review from Sneezry Aug 3, 2018

@Sneezry

This comment has been minimized.

Copy link
Member

Sneezry commented Aug 4, 2018

I pushed some change to this branch. How about this one?

@Sneezry

Sneezry approved these changes Aug 4, 2018

@mymindstorm

This comment has been minimized.

Copy link
Member Author

mymindstorm commented Aug 4, 2018

Can't seem to make it more visible.

image

@Sneezry

This comment has been minimized.

Copy link
Member

Sneezry commented Aug 5, 2018

Changed border and shadow color to #cccccc

@mymindstorm

This comment has been minimized.

Copy link
Member Author

mymindstorm commented Aug 5, 2018

So it turns out it just didn't want to render the stroke for some reason. The process to find that out was frustrating.

@Sneezry Sneezry merged commit 7205853 into dev Aug 6, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Sneezry Sneezry deleted the logo-svg branch Aug 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.