New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qr scanner ui #247

Merged
merged 2 commits into from Nov 27, 2018

Conversation

2 participants
@Sneezry
Member

Sneezry commented Nov 26, 2018

#246

This pr changes qr ui and user experience to abort selection.

  1. When click scan qr icon, a light layer will cover the current page instead of the dark one to make cursor easy to find.

  2. Selection can be canceled by pressing ESC key.

snipaste20181126_155145

@Sneezry Sneezry requested a review from mymindstorm Nov 26, 2018

@Sneezry Sneezry merged commit 0a1ee2e into dev Nov 27, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Sneezry Sneezry deleted the qr-ui branch Nov 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment