Skip to content

Conversation

@Sneezry
Copy link
Member

@Sneezry Sneezry commented Jul 9, 2021

fix #705

@Sneezry Sneezry requested a review from mymindstorm July 9, 2021 18:12
@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #706 (a936d5d) into dev (af907ee) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #706   +/-   ##
=======================================
  Coverage   18.34%   18.34%           
=======================================
  Files          15       15           
  Lines        1488     1488           
  Branches      324      324           
=======================================
  Hits          273      273           
  Misses       1182     1182           
  Partials       33       33           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af907ee...a936d5d. Read the comment docs.

Copy link
Member

@mymindstorm mymindstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more of a larger issue with how we are checking for encrypted entries rather than just this conditional. With the key encryption, all of these encryption checks should be looking for if there is a key present rather than an encrypted entry. I will look into writing some code for this.

@Sneezry
Copy link
Member Author

Sneezry commented Jul 12, 2021

This is more of a larger issue with how we are checking for encrypted entries rather than just this conditional. With the key encryption, all of these encryption checks should be looking for if there is a key present rather than an encrypted entry.

I agree. When there is no entries, and a password is set, current logic will just ignore the key.

@mymindstorm
Copy link
Member

Closing in favor of #724

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scan QR code, get "You cannot add an account until all accounts are decrypted"

3 participants