diff --git a/src/main/java/net/authorize/api/controller/ARBGetSubscriptionListController.java b/src/main/java/net/authorize/api/controller/ARBGetSubscriptionListController.java index efdc7c89..a030d094 100644 --- a/src/main/java/net/authorize/api/controller/ARBGetSubscriptionListController.java +++ b/src/main/java/net/authorize/api/controller/ARBGetSubscriptionListController.java @@ -17,9 +17,7 @@ protected void validateRequest() { //validate required fields if ( null == request.getSearchType()) throw new NullPointerException("SearchType cannot be null"); - if ( null == request.getPaging()) throw new NullPointerException("Paging cannot be null"); - - //validate not-required fields + } @Override diff --git a/src/test/java/net/authorize/api/controller/test/ArbSubscriptionTest.java b/src/test/java/net/authorize/api/controller/test/ArbSubscriptionTest.java index f17561f4..8c9c82a4 100644 --- a/src/test/java/net/authorize/api/controller/test/ArbSubscriptionTest.java +++ b/src/test/java/net/authorize/api/controller/test/ArbSubscriptionTest.java @@ -108,8 +108,27 @@ public void testSubscription() throws Exception { String subscriptionId = createSubscription(merchantAuthenticationType); getSubscription(merchantAuthenticationType, subscriptionId); cancelSubscription(merchantAuthenticationType, subscriptionId); + } - + + + /** + * @Zalak + * Repro and fix test for issue - ARBSubscriptionList SearchType of "cardExpiringThisMonth" doesn't work + */ + @Test + public void ShouldReturnSubsciptionsWhenPagingNotPassedTest() + { + ARBGetSubscriptionListRequest getSubscriptionListRequest = new ARBGetSubscriptionListRequest(); + getSubscriptionListRequest.setSearchType(ARBGetSubscriptionListSearchTypeEnum.CARD_EXPIRING_THIS_MONTH); + getSubscriptionListRequest.setMerchantAuthentication(merchantAuthenticationType); + ARBGetSubscriptionListController nullController = new ARBGetSubscriptionListController(getSubscriptionListRequest); + Assert.assertNotNull(nullController); + ARBGetSubscriptionListResponse response = executeTestRequestWithSuccess(getSubscriptionListRequest, ARBGetSubscriptionListController.class, environment); + Assert.assertNotNull(response); + + } + private ARBGetSubscriptionListRequest setupSubscriptionListRequest(MerchantAuthenticationType merchantAuthentication) { ARBGetSubscriptionListSorting sorting = new ARBGetSubscriptionListSorting(); @@ -166,4 +185,6 @@ private String createSubscription( MerchantAuthenticationType merchantAuthentica return createResponse.getSubscriptionId(); } + + }