Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby conventions #167

Open
SampsonCrowley opened this issue Oct 5, 2018 · 3 comments
Open

ruby conventions #167

SampsonCrowley opened this issue Oct 5, 2018 · 3 comments
Labels

Comments

@SampsonCrowley
Copy link

@SampsonCrowley SampsonCrowley commented Oct 5, 2018

Your ruby code blantantly ignores most ruby conventions (e.g. underscore_method_names) and uses (what looks like) java based naming schemes everywhere

Is an expectation to migrate this sdk to use ruby conventions ever going to be reasonable for a major release? I wouldn't mind helping, if that isn't something you would be opposed to

@SampsonCrowley

This comment has been minimized.

Copy link
Author

@SampsonCrowley SampsonCrowley commented Oct 5, 2018

also related to #143

@gnongsie

This comment has been minimized.

Copy link
Contributor

@gnongsie gnongsie commented Oct 23, 2018

Hi,

Thank you for your suggestions and offer.

This message has been communicated to the team and we will try to adhere to the conventions of the language as much as possible.

We will keep you in mind, should any help be required.

@gnongsie gnongsie added the redesign label Oct 23, 2018
@taf2

This comment has been minimized.

Copy link

@taf2 taf2 commented Jan 13, 2020

I believe this also is breaking rails 6 with zeitwerk

Hold on, I am eager loading the application.

WARNING: The files in these directories cannot be checked because they
are not eager loaded:

  /Users/taf2/.rvm/gems/ruby-2.6.5@ctm3/gems/authorizenet-2.0.0/lib/app/helpers

You may verify them manually, or add them to config.eager_load_paths
in config/application.rb and run zeitwerk:check again.

Otherwise, all is good!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.