New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: remove 'Feature:' line from files being imported #66

Closed
blahDL opened this Issue Dec 13, 2016 · 3 comments

Comments

2 participants
@blahDL

blahDL commented Dec 13, 2016

When importing fragments using #IMPORT: if you remove the Feature line you can then create one feature file that contains a superset of features.

e.g.

  1. logic.path.one.feature (contains tests for one path through the app)
  2. logic.path.two.feature (contains tests for a different path through the app)
  3. logic.feature (imports logic.path.one.feature and logic.path.two.feature to test both paths)
@mcasperson

This comment has been minimized.

Show comment
Hide comment
@mcasperson

mcasperson Dec 14, 2016

Collaborator

See the testFeatureImport() test in https://github.com/mcasperson/IridiumApplicationTesting/blob/master/src/test/java/au/com/agic/apptesting/LiveTests.java, and the files https://mcasperson.github.io/iridium/features/parent.feature and https://mcasperson.github.io/iridium/features/child.feature.

When importing a feature file, all contents up to the first Scenario is removed.

This will be included with the next release.

Collaborator

mcasperson commented Dec 14, 2016

See the testFeatureImport() test in https://github.com/mcasperson/IridiumApplicationTesting/blob/master/src/test/java/au/com/agic/apptesting/LiveTests.java, and the files https://mcasperson.github.io/iridium/features/parent.feature and https://mcasperson.github.io/iridium/features/child.feature.

When importing a feature file, all contents up to the first Scenario is removed.

This will be included with the next release.

@mcasperson mcasperson closed this Dec 18, 2016

@blahDL

This comment has been minimized.

Show comment
Hide comment
@blahDL

blahDL Jan 5, 2017

I just spent a few hours tracking down why this wasn't working as expected. The reason is windows style line endings \r\n whereas your code only works with unix style line endings \n. After I changed the line endings it worked as expected.

blahDL commented Jan 5, 2017

I just spent a few hours tracking down why this wasn't working as expected. The reason is windows style line endings \r\n whereas your code only works with unix style line endings \n. After I changed the line endings it worked as expected.

@mcasperson

This comment has been minimized.

Show comment
Hide comment
@mcasperson
Collaborator

mcasperson commented Jan 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment