New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feature) Two steps have been added to modify HTTP headers #78

Merged
merged 2 commits into from Jan 6, 2017

Conversation

3 participants
@idooo
Contributor

idooo commented Jan 4, 2017

ONLINE-544

@idooo idooo self-assigned this Jan 4, 2017

@idooo idooo requested review from mcasperson and sohilpatel Jan 4, 2017

@mcasperson

Looks good. Can you add the new steps to the steptest.feature file. This won't check that the headers are changed, but will ensure the steps are run and are valid, as this feature file is run by Travis CI with each commit.

@mcasperson

This comment has been minimized.

Show comment
Hide comment
@mcasperson

mcasperson Jan 5, 2017

Collaborator

Also can you add the new steps to https://github.com/mcasperson/iridium-snippets/tree/master/snippets, which is the atom plugin for iridium.

Collaborator

mcasperson commented Jan 5, 2017

Also can you add the new steps to https://github.com/mcasperson/iridium-snippets/tree/master/snippets, which is the atom plugin for iridium.

@mcasperson mcasperson merged commit e3338a3 into AutoGeneral:master Jan 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment