From bd1dc99a4e5bcb7eb73bb6d8b133eea1989b004d Mon Sep 17 00:00:00 2001 From: Bruce Date: Fri, 26 Apr 2024 15:30:37 +0800 Subject: [PATCH] feat(automq-kafka-admin.sh): Optimize command line standard output messages (#1178) --- .../org/apache/kafka/tools/automq/GenerateS3UrlCmd.java | 6 +++--- .../org/apache/kafka/tools/automq/GenerateStartCmdCmd.java | 7 +++---- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/tools/src/main/java/org/apache/kafka/tools/automq/GenerateS3UrlCmd.java b/tools/src/main/java/org/apache/kafka/tools/automq/GenerateS3UrlCmd.java index f490187d21..f961e2fe41 100644 --- a/tools/src/main/java/org/apache/kafka/tools/automq/GenerateS3UrlCmd.java +++ b/tools/src/main/java/org/apache/kafka/tools/automq/GenerateS3UrlCmd.java @@ -146,7 +146,7 @@ public static ArgumentParser addArguments(Subparser parser) { } public String run() { - System.out.println("############ Ping s3 ####################"); + System.out.println("############ Ping s3 ########################"); System.out.println(); // precheck @@ -160,13 +160,13 @@ public String run() { S3Utils.checkS3Access(context); String s3Url = buildS3Url(); - System.out.println("############ string of s3url ############"); + System.out.println("############ String of s3url ################"); System.out.println(); System.out.println("Your s3url is: \n"); System.out.println(s3Url); System.out.println("\n"); - System.out.println("############ s3url usage ################"); + System.out.println("############ Usage of s3url ################"); System.out.println("To start AutoMQ, generate the start commandline using s3url."); //tips: Not add whitespace after \\ System.out.println(String.format("bin/automq-kafka-admin.sh %s \\%n" diff --git a/tools/src/main/java/org/apache/kafka/tools/automq/GenerateStartCmdCmd.java b/tools/src/main/java/org/apache/kafka/tools/automq/GenerateStartCmdCmd.java index 7f58bb4f9c..040a2acdcc 100644 --- a/tools/src/main/java/org/apache/kafka/tools/automq/GenerateStartCmdCmd.java +++ b/tools/src/main/java/org/apache/kafka/tools/automq/GenerateStartCmdCmd.java @@ -105,11 +105,10 @@ public void run() throws IOException { ServerGroupConfig controllerGroupConfig = ConfigParserUtil.genControllerConfig(parameter.controllerList, parameter.controllerOnlyMode); ServerGroupConfig brokerGroupConfig = ConfigParserUtil.genBrokerConfig(parameter.brokerList, controllerGroupConfig); - System.out.println("############## START CMD LIST ###########"); - System.out.println("You can copy the command to where your AutoMQ tgz located and run following command to start a AutoMQ kafka server: \n"); - System.out.println("Ensure that your compute instance already have JDK17 installed. Execute 'java -version' to check."); + System.out.println("############ Start Commandline ##############"); + System.out.println("To start an AutoMQ Kafka server, please navigate to the directory where your AutoMQ tgz file is located and run the following command. \n"); + System.out.println("Before running the command, make sure that JDK17 is installed on your host. You can verify the Java version by executing 'java -version'."); System.out.println(); - System.out.println("------------------------ COPY ME ------------------"); for (int controllerNodeId : controllerGroupConfig.getNodeIdList()) { if (parameter.controllerOnlyMode) {