From 58aeaa5a90539787ddafb096f6d89d00a1e83ed9 Mon Sep 17 00:00:00 2001 From: Curtis Wan Date: Mon, 5 Feb 2024 15:37:22 +0800 Subject: [PATCH 1/2] fix(core): release only if it is PooledResource Signed-off-by: Curtis Wan --- core/src/main/scala/kafka/server/KafkaApis.scala | 2 +- fail.yml | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) create mode 100644 fail.yml diff --git a/core/src/main/scala/kafka/server/KafkaApis.scala b/core/src/main/scala/kafka/server/KafkaApis.scala index 3684817fda..3d914361c0 100644 --- a/core/src/main/scala/kafka/server/KafkaApis.scala +++ b/core/src/main/scala/kafka/server/KafkaApis.scala @@ -996,7 +996,7 @@ class KafkaApis(val requestChannel: RequestChannel, def release(): Unit = { partitions.values().forEach(data => { - if (data.records() != null) { + if (data.records() != null && data.records().isInstanceOf[PooledResource]) { data.records().asInstanceOf[PooledResource].release() } }) diff --git a/fail.yml b/fail.yml new file mode 100644 index 0000000000..cebcbd10cf --- /dev/null +++ b/fail.yml @@ -0,0 +1,4 @@ +2024-02-04--001: +#- tests/kafkatest/tests/core/group_mode_transactions_test.py::GroupModeTransactionsTest.test_transactions@{"failure_mode":"hard_bounce","bounce_target":"brokers"} +- tests/kafkatest/tests/client/quota_test.py::QuotaTest.test_quota@{"quota_type":"client-id","old_client_throttling_behavior":true} + From 47654b49abaad0292fedea63b267d0c0c01c605d Mon Sep 17 00:00:00 2001 From: Curtis Wan Date: Mon, 5 Feb 2024 15:41:57 +0800 Subject: [PATCH 2/2] fix: delete unnecessary file Signed-off-by: Curtis Wan --- fail.yml | 4 ---- 1 file changed, 4 deletions(-) delete mode 100644 fail.yml diff --git a/fail.yml b/fail.yml deleted file mode 100644 index cebcbd10cf..0000000000 --- a/fail.yml +++ /dev/null @@ -1,4 +0,0 @@ -2024-02-04--001: -#- tests/kafkatest/tests/core/group_mode_transactions_test.py::GroupModeTransactionsTest.test_transactions@{"failure_mode":"hard_bounce","bounce_target":"brokers"} -- tests/kafkatest/tests/client/quota_test.py::QuotaTest.test_quota@{"quota_type":"client-id","old_client_throttling_behavior":true} -