Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spot requests fail when no SSH key is configured #16

Closed
snordhausen opened this issue Sep 22, 2016 · 6 comments

Comments

@snordhausen
Copy link

commented Sep 22, 2016

Hi!

While playing around with autospotting, I configured a Launch Configuration that did not define an SSH key. In this setup, the spot requests failed with this error message:

failed: Invalid value '' for keyPairNames. It should not be blank (400 response code)
bad-parameters: Your Spot request failed due to bad parameters.

It would be nice if autospotting supported this setup.

@cristim

This comment has been minimized.

Copy link
Member

commented Sep 22, 2016

AutoSpotting couldn't care less about this, but unfortunately it seems the AWS spot request needs that field, even if AutoScaling doesn't need it.

It's likely one of those cases that show how AWS EC2 was built by different teams that didn't really care about synchronizing their JSON fields.

You can try launching a spot request with the AWS CLI tool that is also missing the SSH key field, if that works, then it is indeed an autospotting bug and I'll have to look into it in more detail.

@snordhausen

This comment has been minimized.

Copy link
Author

commented Sep 22, 2016

I tried it out using the AWS CLI. When the field was empty, I got exactly the error message that autospotting produced. But when I completely removed the KeyName field from the JSON, the request works and I get an instance. Autospotting would have to do the same.

@cristim

This comment has been minimized.

Copy link
Member

commented Sep 22, 2016

Thanks, that's great information and looks like an easy fix. Patches are always welcome :-)

@cristim cristim added the Type: Bug label Sep 22, 2016

@cristim cristim closed this in 8934c01 Sep 24, 2016

@cristim

This comment has been minimized.

Copy link
Member

commented Sep 26, 2016

Reopening, pending user confirmation.

@snordhausen please let me know if you still notice this issue, it should now be fixed.

@cristim cristim reopened this Sep 26, 2016

@snordhausen

This comment has been minimized.

Copy link
Author

commented Sep 28, 2016

Works as it should. Thanks for the quick fix!

@cristim

This comment has been minimized.

Copy link
Member

commented Sep 28, 2016

@snordhausen Thanks for the confirmation, please let me know if you notice any other issues.

@cristim cristim self-assigned this Nov 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.