chore: update README.md to emphasize the importance of importing styles #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d styles.css file
robbienohra
changed the title
Contributor
Author
|
following up on this |
nihgwu
reviewed
Jan 11, 2021
README.md
Outdated
| ... | ||
| ``` | ||
|
|
||
| > __Important:__ if you fail to import `react-base-table/styles.css` then `BaseTable` will not render as advertised in the included examples. |
Contributor
There was a problem hiding this comment.
I think you can move the instruction to code snippet above as an comment, and point to the advanced customize style section as well
Contributor
Author
There was a problem hiding this comment.
K implemented your suggestion, let me if you'd like it to to be further tweaked!
nihgwu
reviewed
Jan 23, 2021
README.md
Outdated
Comment on lines
38
to
39
|
|
||
|
|
Contributor
There was a problem hiding this comment.
although has no effect on rendered format, but nice to be removed
README.md
Outdated
| // Important: if you fail to import react-base-table/styles.css then | ||
| // BaseTable will not render as advertised in the included examples. | ||
| // For advanced styling see link below: | ||
| // https://github.com/Autodesk/react-base-table/blob/master/docs/advance.md |
Contributor
There was a problem hiding this comment.
https://github.com/Autodesk/react-base-table#advance this link would be better?
Contributor
There was a problem hiding this comment.
You are lightning fast, thank you 👍
nihgwu
approved these changes
Jan 23, 2021
nihgwu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-base-table/styles.cssin order forBaseTableto render as advertised in examples