From b4e5705307dba0af5e17548f4d8395a6e6b21096 Mon Sep 17 00:00:00 2001 From: Robbie Nohra Date: Tue, 15 Dec 2020 17:53:04 -0500 Subject: [PATCH 1/4] initial draft of README me message to emphasize importance of included styles.css file --- README.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index cdfd981d..4d18e4c1 100644 --- a/README.md +++ b/README.md @@ -18,7 +18,7 @@ yarn add react-base-table ``` ## Usage - +i ```js import BaseTable, { Column } from 'react-base-table' import 'react-base-table/styles.css' @@ -32,6 +32,8 @@ import 'react-base-table/styles.css' ... ``` +> __Important:__ if you fail to import `react-base-table/styles.css` then `BaseTable` will not render as advertised in the included examples. + Learn more at the [website](https://autodesk.github.io/react-base-table/) ### unique key From b5880ffef3bade0cd57c67bb01fb94b051b4ea92 Mon Sep 17 00:00:00 2001 From: Robbie Nohra Date: Tue, 15 Dec 2020 18:06:05 -0500 Subject: [PATCH 2/4] remove accidentally added characters --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 4d18e4c1..92d4874f 100644 --- a/README.md +++ b/README.md @@ -18,7 +18,7 @@ yarn add react-base-table ``` ## Usage -i + ```js import BaseTable, { Column } from 'react-base-table' import 'react-base-table/styles.css' From 3d2983a7d30ef3b845c1c244f87bd864c1aa795d Mon Sep 17 00:00:00 2001 From: Robbie Nohra Date: Thu, 21 Jan 2021 23:23:36 -0500 Subject: [PATCH 3/4] repositioned style message in code snippet --- README.md | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 92d4874f..4a8fcd06 100644 --- a/README.md +++ b/README.md @@ -22,8 +22,11 @@ yarn add react-base-table ```js import BaseTable, { Column } from 'react-base-table' import 'react-base-table/styles.css' - -... +// Important: if you fail to import react-base-table/styles.css then +// BaseTable will not render as advertised in the included examples. +// For advanced styling see link below: +// https://github.com/Autodesk/react-base-table/blob/master/docs/advance.md + ... @@ -32,7 +35,7 @@ import 'react-base-table/styles.css' ... ``` -> __Important:__ if you fail to import `react-base-table/styles.css` then `BaseTable` will not render as advertised in the included examples. + Learn more at the [website](https://autodesk.github.io/react-base-table/) From db6f3cb753be50502420a6d50d10a9975ba4bc9a Mon Sep 17 00:00:00 2001 From: Robbie Nohra Date: Fri, 22 Jan 2021 19:59:37 -0500 Subject: [PATCH 4/4] fix: remove extraneous whitespace and use more relevant advanced styling link --- README.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/README.md b/README.md index 4a8fcd06..b55c3cd6 100644 --- a/README.md +++ b/README.md @@ -25,7 +25,7 @@ import 'react-base-table/styles.css' // Important: if you fail to import react-base-table/styles.css then // BaseTable will not render as advertised in the included examples. // For advanced styling see link below: -// https://github.com/Autodesk/react-base-table/blob/master/docs/advance.md +// https://github.com/Autodesk/react-base-table#advance ... @@ -35,8 +35,6 @@ import 'react-base-table/styles.css' ... ``` - - Learn more at the [website](https://autodesk.github.io/react-base-table/) ### unique key