Skip to content

Commit

Permalink
Revert "Bail if we don't find a matching code"
Browse files Browse the repository at this point in the history
This reverts commit d2d9b06.

Ended up causing issues on some VIP sites and the original problem this
was tackling ended up being a different problem altogether.
  • Loading branch information
mjangda committed Dec 30, 2013
1 parent d2d9b06 commit 746f97e
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions ad-code-manager.php
Expand Up @@ -848,9 +848,6 @@ function action_acm_tag( $tag_id, $echo = true ) {


$code_to_display = $this->get_matching_ad_code( $tag_id ); $code_to_display = $this->get_matching_ad_code( $tag_id );


if ( empty( $code_to_display ) )
return;

// Run $url aganist a whitelist to make sure it's a safe URL // Run $url aganist a whitelist to make sure it's a safe URL
if ( !$this->validate_script_url( $code_to_display['url'] ) ) if ( !$this->validate_script_url( $code_to_display['url'] ) )
return; return;
Expand Down

1 comment on commit 746f97e

@mjangda
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hazy on the specifics (happened 3 months ago) which is there isn't much detail here :(

Please sign in to comment.