Skip to content

Enable using ad codes with empty filters using a filter #16

Closed
danielbachhuber opened this Issue Apr 5, 2012 · 0 comments

1 participant

@danielbachhuber

Initial conversation: http://adcodemanager.wordpress.com/2012/04/05/in-a-recent-commit-rinat-modifies-the-following/

Basically, the current behavior is to display an ad code if the logical operator is set to AND and the ad code has no conditionals. This is probably the incorrect behavior. The post describes adding an "ALL" logical operator, but "ALL" isn't really a logical operator. Let's make this behavior opt-in with a filter instead.

@danielbachhuber danielbachhuber added a commit that closed this issue Apr 5, 2012
@danielbachhuber danielbachhuber New filter allows implementors to change the behavior of ACM as it co…
…mes to determining whether to display an ad code or not.

By default, ACM will ignore any ad codes without conditionals. This prevents them from showing up on the frontend as soon as an admin saves the code.

Modify this value to true to have your ad codes appear on the frontend without conditionals

Fixes #16
229436a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.