Update readme and ship 0.4.3 #67

Open
danielbachhuber opened this Issue Apr 12, 2013 · 3 comments

Comments

Projects
None yet
2 participants
Collaborator

danielbachhuber commented Apr 12, 2013

Let's get this out as a bugfix release before v0.5

@danielbachhuber danielbachhuber modified the milestone: 0.4.3, 0.4.1 Feb 6, 2014

jb510 commented Feb 16, 2014

This may sound trivial but adding an explanation of what Tag ID, DFP ID, and Tag Name are andwhat format they should look (ca-pub-XXXXXXXXXXXXXXXX) like would help tremendously for people like this: http://wordpress.org/support/topic/how-to-get-the-tag-id-dfp-id-tag-name-from-adsense-google-admanager
(and people like me too)

I think it's nearly mandatory in the readme, but it'd also be nice inline on the config page (since large number of people won't read the readme)

Collaborator

danielbachhuber commented Feb 17, 2014

@jb510 up for submitting a pull request for this?

jb510 commented Feb 18, 2014

I would, but I'm not familiar enough with Adsense/DoubleClick to be confident what those things are in each case (still trying to get this plugin working for the first time). When I get it functional and know what those things are, yes I'll definitely update my fork and put in a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment