Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to delete a guest author #30

Closed
danielbachhuber opened this issue May 5, 2012 · 3 comments
Closed

Ability to delete a guest author #30

danielbachhuber opened this issue May 5, 2012 · 3 comments
Assignees
@danielbachhuber
Milestone
v3.0

Comments

@danielbachhuber
Copy link
Contributor

Admins should be able to permanently delete a guest author. In doing so, we should prompt them to do one of three things:

  • If the guest author is associated with a WordPress user, allow them to leave the posts associated with the user. This results in the guest author post being deleted but the 'author' taxonomy term being left as it is.
  • Similarly, if the guest author doesn't have an associated WordPress user, the guest author post object is deleted and the corresponding 'author' taxonomy term is left associated with their bylined posts. This allows the admin to create the guest author again at a later date.
  • Allow the admin to reassign the guest author's posts to another guest author or WordPress user. This results in the guest author post object being deleted and all posts associated with the 'author' taxonomy term being reassigned to the new author.
  • Allow the admin to delete all posts associated with the guest author, in addition to their guest author post object.
@ghost ghost assigned danielbachhuber May 30, 2012
danielbachhuber added a commit that referenced this issue Oct 12, 2012
@danielbachhuber
First pass at allowing guest authors to be deleted. It currently supp…
25cc010 
…orts two scenarios:

* Delete the guest author and reassociate the bylines with the linked user
* Delete the guest author and leave the post

See #30
@danielbachhuber
Copy link
Contributor Author

@mjangda I've got two scenarios worked out and two more to go:

  1. Delete the guest author and all of their associated posts
  2. Delete the guest author but reassign their posts to an arbitrary user or guest author

The first is difficult because I think I have to get all post IDs, and then run wp_delete_post() for each. Do you have a better idea?

The second is difficult because I need to create a merged select list with all users and guest authors. Any ideas?

danielbachhuber added a commit that referenced this issue Oct 19, 2012
@danielbachhuber
Clarifying text for the scenario where you'd like to delete the guest…
6fe8099 
… author *and* their posts.

For this first release, we won't support deleting the guest author and all of their posts

See #30
danielbachhuber added a commit that referenced this issue Oct 26, 2012
@danielbachhuber
Keep the "Confirm Deletion" button disabled until an option is explic…
322116d 
…itly chosen.

See #30
danielbachhuber added a commit that referenced this issue Oct 31, 2012
@danielbachhuber
Allow guest authors to be created from users, even when they may not …
53761a0 
…have display_name, first_name or last_name fields.

We're doing our best to avoid the situation where a guest author is created with the same user_login as a user. In this scenario, they share the same author term which means that any modifications to one lead to modifications to the other. Where this is the biggest possibility is if the guest author becomes unmapped to the user, posts are continued to be assigned to it, and then the guest author is deleted.

So, the easiest thing to do is restrict the mapping from being changed

See #28, #30
danielbachhuber added a commit that referenced this issue Nov 8, 2012
@danielbachhuber
Guest Authors: Upon deleting, allow a guest author's post to be reass…
de7d36c 
…igned to another coauthor

See #30
@danielbachhuber
Copy link
Contributor Author

The one annoying thing left on this is if you select a coauthor to reassign to, the radio button doesn't get automagically selected.

danielbachhuber added a commit that referenced this issue Nov 11, 2012
@danielbachhuber
Guest Authors: Refactor deleting approach to use a common delete() me…
b4f3854 
…thod

This delete() method ensures DRY and also that all related caches will be deleted when the guest author is deleted

Closes #80
See #30
danielbachhuber added a commit that referenced this issue Nov 11, 2012
@danielbachhuber
Guest Authors: Always show the display name when deleting, as the PHP…
0bf7077 
… will fall back to rendering user_login if the display name isn't available

Also, when a user has selected a guest author to reassign to, trigger the click event for the radio button

See #30
@danielbachhuber
Copy link
Contributor Author

This is finished up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielbachhuber danielbachhuber

Labels
None yet
Projects
None yet
Milestone
v3.0
Development

No branches or pull requests
1 participant
@danielbachhuber