Fix for pull 67: Map author slugs to user_nicename #90

Merged
merged 2 commits into from Dec 22, 2012

Conversation

Projects
None yet
2 participants
@STRML
Contributor

STRML commented Nov 29, 2012

Pull 67 was incomplete. Contains wp-admin fixes to complete the move to user_nicename.

Essentially, the hidden field in the wp-admin post edit screen passes user_login to the backend, which then attempts to look up a user by user_nicename. This works in most cases except when users have an email address as a login name, which converts to a url safe user_nicename (e.g. "mail@example.com" -> "mailexample-com").

This pull fixes this issue by exporting user_nicename to the template and passing it via javascript to the hidden field.

@danielbachhuber

This comment has been minimized.

Show comment Hide comment
@danielbachhuber

danielbachhuber Dec 12, 2012

Collaborator
Collaborator

danielbachhuber commented Dec 12, 2012

@ghost ghost assigned danielbachhuber Dec 12, 2012

@danielbachhuber

This comment has been minimized.

Show comment Hide comment
@danielbachhuber

danielbachhuber Dec 13, 2012

Collaborator

Sorry, I didn't have a chance to look at this yet :( I'm headed offline for a few days but it's at the top of my list for when I get back.

Collaborator

danielbachhuber commented Dec 13, 2012

Sorry, I didn't have a chance to look at this yet :( I'm headed offline for a few days but it's at the top of my list for when I get back.

danielbachhuber added a commit that referenced this pull request Dec 22, 2012

Merge pull request #90 from byt/master
Fix for pull 67: Map author slugs to user_nicename. Props @STRML

@danielbachhuber danielbachhuber merged commit dfcfab0 into Automattic:master Dec 22, 2012

danielbachhuber added a commit that referenced this pull request Dec 22, 2012

@danielbachhuber

This comment has been minimized.

Show comment Hide comment
@danielbachhuber

danielbachhuber Dec 22, 2012

Collaborator

Thanks much. This is now live on WordPress.com and I hope to release the improvement with the plugin at the end of next week.

Collaborator

danielbachhuber commented Dec 22, 2012

Thanks much. This is now live on WordPress.com and I hope to release the improvement with the plugin at the end of next week.

@STRML

This comment has been minimized.

Show comment Hide comment
@STRML

STRML Dec 22, 2012

Contributor

Glad it made it through - when 3.0.4 comes out I can finally update my sites. I appreciate the attention to the issue.

Contributor

STRML commented Dec 22, 2012

Glad it made it through - when 3.0.4 comes out I can finally update my sites. I appreciate the attention to the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment