Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

A follow link for Manage Posts, Calendar, and Story Budget #185

Merged
merged 5 commits into from Mar 19, 2013

Conversation

Projects
None yet
3 participants
Collaborator

danielbachhuber commented Mar 18, 2013

This adds a "Follow" link to post row actions to Manage Posts, Calendar, and Story budget views. It also removes the unfollowing_users taxonomy, as that hasn't ever been used, and refactors follow_post_users and unfollow_post_users(), as the latter hasn't ever worked.

Lastly, it refactors the row actions for the Story Budget so it's easy to hook on this follow link

danielbachhuber and others added some commits Mar 18, 2013

@danielbachhuber danielbachhuber A follow link for Manage Posts, Calendar, and Story Budget
This adds a "Follow" link to post row actions to Manage Posts, Calendar, and Story budget views. It also removes the unfollowing_users taxonomy, as that hasn't ever been used, and refactors follow_post_users and unfollow_post_users(), as the latter hasn't ever worked.

Lastly, it refactors the row actions for the Story Budget so it's easy to hook on this follow link

See #130
fd52687
@rgalindo05 @danielbachhuber rgalindo05 Linked features from dashboard d0dbfb9
@danielbachhuber danielbachhuber Proper use of sprintf, and consolidate some code 2258677
@danielbachhuber danielbachhuber Props for #185 e760682
@danielbachhuber danielbachhuber A different way of binding events, which means the event is dynamical…
…ly bound instead of static.
ef2aa2d

@danielbachhuber danielbachhuber added a commit that referenced this pull request Mar 19, 2013

@danielbachhuber danielbachhuber Merge pull request #185 from Automattic/follow-link
A follow link for Manage Posts, Calendar, and Story Budget
c5c7701

@danielbachhuber danielbachhuber merged commit c5c7701 into master Mar 19, 2013

@danielbachhuber danielbachhuber deleted the follow-link branch Mar 19, 2013

@danielbachhuber danielbachhuber added a commit that referenced this pull request Mar 19, 2013

@danielbachhuber danielbachhuber Update readme for #185 fb63bfd
Collaborator

cojennin commented on ef2aa2d Mar 19, 2013

I don't know if this is happening with anybody else, but this is causing me a bit of trouble in the Budget and 'Manage Posts' view. I think it may be because '#ef-calendar-view' only exists in the calendar section. Could the selectors be doubled up to form ('.ef_follow_link, #ef-calendar-view') so that there's a fallback option?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment