New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add salary field to satisfy Google's Job Search schema #1320

Open
aheckler opened this Issue Feb 9, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@aheckler
Copy link
Member

aheckler commented Feb 9, 2018

Assuming a user fills out all the job form fields correctly, Google will still throw a warning (not an error) because listings do not have a salary by default. We should consider adding this:

https://wpjobmanager.com/document/tutorial-adding-a-salary-field-for-jobs/

... to the core plugin, IMHO.

We should also consider renaming the Location field to Address, since if you don't enter an exact street address, Google will throw other warnings (or actual errors, depending on how the user enters the location). Address is less ambiguous in this regard.

Related to #1313

@jom

This comment has been minimized.

Copy link
Member

jom commented Feb 12, 2018

I agree that we should add a salary field. Is it safe enough to just add the field and provide a filter snippet for folks who want to remove it as a field?

For the Location/Address, I take it these are errors in the schema check and not background address fetching from Google Maps?

@aheckler

This comment has been minimized.

Copy link
Member

aheckler commented Feb 12, 2018

Is it safe enough to just add the field and provide a filter snippet for folks who want to remove it as a field?

I don't even think we need to provide a filter really. We don't provide a specific filter for any of the other default fields. People can already use submit_job_form_fields to unset whatever they don't want.

For the Location/Address, I take it these are errors in the schema check and not background address fetching from Google Maps?

Correct, yeah. It's nothing we're doing ourselves, but we can help the user avoid errors in the schema check if we make the label more accurately reflect what they need to enter to pass the check.

@jom

This comment has been minimized.

Copy link
Member

jom commented Feb 12, 2018

People can already use submit_job_form_fields to unset whatever they don't want.

Yup, I meant documenting a snippet on wpjobmanager.com that uses submit_job_form_fields.

Correct, yeah. It's nothing we're doing ourselves, but we can help the user avoid errors in the schema check if we make the label more accurately reflect what they need to enter to pass the check.

Alrighty. I might break this ticket up. I feel like I've seen Location more than Address on job listing sites, but we could try it out. I think we'll need to rethink that field anyway to support remote jobs (#918).

@aheckler

This comment has been minimized.

Copy link
Member

aheckler commented Feb 12, 2018

I meant documenting a snippet on wpjobmanager.com that uses submit_job_form_fields.

I can do this when we merge, yeah.

I feel like I've seen Location more than Address on job listing sites, but we could try it out.

Yeah, it's a tough call.

People probably aren't used to putting in exact addresses on job listing sites. But Google says: "The more properties you provide, the higher quality the job posting is to our users." (Source.) And people always want to obey Google. ¯\(ツ)

CTRL+F here for TELECOMMUTE to see how they want us to designate remote jobs:

https://developers.google.com/search/docs/data-types/job-posting

That will probably need to be a new checkbox in the default form fields.

@aheckler

This comment has been minimized.

Copy link
Member

aheckler commented Feb 23, 2018

Also, when/if we do add salary to the built-in fields, we should add it to the Indeed job feed XML.

947425-zen

@jom jom changed the title Adjust job fields to satisfy Google's Job Search schema Add salary field to satisfy Google's Job Search schema Mar 27, 2018

@jom jom added this to the 1.32.0 milestone Mar 27, 2018

@RajeebTheGreat RajeebTheGreat referenced a pull request that will close this issue May 28, 2018

Open

Add Salary Field #1510

@jenhooks

This comment has been minimized.

Copy link

jenhooks commented Oct 31, 2018

1512665-zen

@jom jom modified the milestones: 1.32.0, Next major Dec 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment