Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Job Data block #1286

Open
wants to merge 17 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@donnapep
Copy link
Contributor

donnapep commented Jan 11, 2018

Progress towards #1373.

This PR adds the UI for the job data block. Note that the block is not yet fully functional and will be fleshed out in future PRs. In particular, the block does not save its data, and selecting a job type in the sidebar does not show that type in the block.

Testing

Run npm install and npm run build. With Gutenberg enabled, add a new job listing. Confirm that:

  • The job data block is added to the editor automatically.
  • Job Types and Job Categories appear in the Document settings in the sidebar.
  • Job Data meta box does not appear.
  • All fields can be filled out (although not saved).

@donnapep donnapep force-pushed the add/job-listing-block branch 2 times, most recently from 1118fec to 5971e0b Mar 5, 2018

@@ -0,0 +1,25 @@
{

This comment has been minimized.

@spencerfinnell

spencerfinnell Mar 5, 2018

Contributor

This could be replaced with WordPress' presets:

https://github.com/WordPress/gutenberg/blob/master/package.json#L99-L102

This comment has been minimized.

@donnapep

donnapep Mar 6, 2018

Author Contributor

Nice!

BlockDescription,
Editable,
InspectorControls,
MediaUploadButton,

This comment has been minimized.

@spencerfinnell

spencerfinnell Mar 5, 2018

Contributor

This is being removed: WordPress/gutenberg#5398

<InspectorControls key="inspector">
<BlockDescription>
<p>{ __( 'Shows a job listing.' ) }</p>
</BlockDescription>

This comment has been minimized.

@spencerfinnell

spencerfinnell Mar 5, 2018

Contributor

BlockDescriptions are being removed: WordPress/gutenberg#5398

@donnapep

This comment has been minimized.

Copy link
Contributor Author

donnapep commented Mar 5, 2018

Thanks @spencerfinnell. This is still a work in progress and not quite ready for a review just yet. 🙂

@donnapep donnapep self-assigned this Mar 5, 2018

@donnapep donnapep force-pushed the add/job-listing-block branch from 3da23d6 to cf96a5b Mar 5, 2018

@donnapep donnapep requested review from jom and alexsanford Mar 6, 2018

@donnapep

This comment has been minimized.

Copy link
Contributor Author

donnapep commented Mar 6, 2018

@jom @alexsanford This is ready for a review, but it's non-urgent until we get back to working on WPJM again.

@donnapep donnapep changed the title Add Job Listing Gutenberg block Add Job Data block Mar 7, 2018

@donnapep donnapep force-pushed the add/job-listing-block branch from 4c44ee0 to 959e0ea Mar 7, 2018

@jom jom added this to the Future release milestone Jun 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.