Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility styling #1037

Closed
slushman opened this issue Oct 21, 2016 · 3 comments

Comments

Projects
None yet
5 participants
@slushman
Copy link

commented Oct 21, 2016

In the style.css file, line 682 - is there any time you'd want an outline on an element where the tabindex is set to -1? If not, couldn't we change that to:

So the outline: 0; applies to any element with a tabindex of -1? I'm trying to understand why the selector here is so specific. Can someone explain?

@samikeijonen

This comment has been minimized.

Copy link
Contributor

commented Nov 12, 2016

I'm not sure why it's that specific. Maybe just because _s only wants to style the #content where it adds the tabindex="-1" and let theme authors decide other styling.

This is remotly related to ticket #1046 also.

@mrwweb

This comment has been minimized.

Copy link
Contributor

commented Dec 25, 2016

I bet @samikeijonen is right. In cases where one uses target/anchor links for in-page navigation, I could imagine one might want the focus style to indicate where focus moved (though in those cases, I personally use :targeted). If one thinks of this style as accompanying the skip-to-content link, the it makes more sense. In that case, then, maybe an explanatory comment makes more sense than making it less specific.

@davidakennedy

This comment has been minimized.

Copy link
Member

commented Jun 9, 2017

Thanks for the issue @slushman! @samikeijonen is right. It was styled that way to be specific so if themes needed to style elements with tabindex, they could do it more easily. Closing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.