New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Landmark Roles #1132

Closed
davidakennedy opened this Issue Jun 23, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@davidakennedy
Member

davidakennedy commented Jun 23, 2017

With WordPress moving ahead with better browser support, and _s supporting Microsoft Internet Explorer 11 and Edge, as well as the latest two versions of all other major browsers, removing the landmarks roles makes sense.

They're implied with the proper HTML5 markup, and warnings are given in most code checking tools if they're added. For more information, see this post from 2015 by Steve Faulkner that recommends dropping them.

We've kept them for quite awhile to have better support with assistive technology, but it's time to move forward.

I brought this up with the WordPress Accessibility team, and they're for it.

Previously:

#786
#797
#889

and probably more. 😄

@davidakennedy davidakennedy self-assigned this Jun 23, 2017

davidakennedy added a commit that referenced this issue Jun 23, 2017

Remove landmark roles
* With better browser support, these roles aren't needed now.
* Most newer browsers imply them via HTML5 semantics. See: http://html5doctor.com/on-html-belts-and-aria-braces/

Fixes #1132
@samikeijonen

This comment has been minimized.

Show comment
Hide comment
@samikeijonen

samikeijonen Jun 23, 2017

Contributor

Go for it.

Contributor

samikeijonen commented Jun 23, 2017

Go for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment