Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Move <title> markup to functions.php #12

Closed
obenland opened this Issue · 4 comments

3 participants

@obenland
Owner

From how I understand the WPTRT guideline on modifying the document title content, it would be best practice to filter 'wp_title' in functions.php and just have

<title><?php wp_title( /* optional params */ ); ?></title>

in header.php.

This would be a huge benefit for all SEO Plugins out there since they could easily modify the title and don't have to worry about stuff being added.

What do you say? :)

@ianstewart
Owner

I've been waiting for http://core.trac.wordpress.org/ticket/18548 to work itself out before moving on this but patches are welcome!

@obenland
Owner

Hm, where would such a 'wp_title' filter function be placed best?
In tweak.php, since it tweaks the default behavior of the wp_title() function?
Or rather in functions.php itself, to make sure to always have a title?

What do you think?

@ianstewart
Owner

Good question. I would probably put it in template-tags or functions.php

@ianstewart ianstewart closed this
@crondeau

Has any progress or change been made on this? I submitted a theme to the repo and it was rejected because of the <title>. The reviewer mentioned the following - Themes are required to modify output via filter (wp_title/body_class/post_class)

(http://themes.trac.wordpress.org/ticket/8447)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.