New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg and _s #1248

Open
samikeijonen opened this Issue Dec 29, 2017 · 8 comments

Comments

Projects
None yet
6 participants
@samikeijonen
Contributor

samikeijonen commented Dec 29, 2017

I'm opening this general issue for Gutenberg in _s. I'm pretty sure _s wants to be 100% ready for Gutenberg, whatever that means :) Because it can mean that

  • let Core handle all the blocks styling etc.
  • _s gives base ideas how themers can work with blocks, styling in the editor and front end etc.
@mor10

This comment has been minimized.

Contributor

mor10 commented Dec 29, 2017

Only practical example I've seen of this so far is from @BinaryMoon: BinaryMoon/granule@777cd29

@caraya

This comment has been minimized.

caraya commented Dec 29, 2017

If you're incorporating Gutenberg it should be opt-in. Let's not forget that WordPress as a CMS is used for a variety of content, not all of which requires blocks.

@mor10

This comment has been minimized.

Contributor

mor10 commented Dec 29, 2017

@caraya Gutenberg is going to be a core feature in WordPress in a few months. Gutenberg support is necessary to allow the theme authors full control over the theme.

@caraya

This comment has been minimized.

caraya commented Dec 30, 2017

@mor10 either through plugins or via some sort of theme customization people who don't want them will remove Gutenberg support. I believe it's better if the removal happens through theme customization, it saves people from having to install yet another Wordpress plugin

Am I missing something?

@mor10

This comment has been minimized.

Contributor

mor10 commented Dec 30, 2017

In the short term, developers can declare lack of Gutenberg support in plugins to force WordPress to fall back on the classic editor. That's a stop-gap measure until plugins have time to update. Blocking Gutenberg at theme level goes against how WordPress will work. Once Gutenberg evolves beyond the editor, which is the next step, blocking it will no longer be a viable option.

@samikeijonen

This comment has been minimized.

Contributor

samikeijonen commented Jan 6, 2018

Here are Gutenberg docs for themes. Mainly about add_theme_support() at the moment.

@crunnells

This comment has been minimized.

Contributor

crunnells commented Feb 27, 2018

The Theme Team here at Automattic is looking at adding Gutenberg support to _s in the near future.

@crunnells crunnells self-assigned this Feb 27, 2018

@crunnells crunnells removed the Needs Patch label Feb 27, 2018

@philiparthurmoore

This comment has been minimized.

Collaborator

philiparthurmoore commented Apr 3, 2018

@crunnells Where's the patch for this? I saw the label has been removed. We could probably remove Second Opinion. It seems unlikely that keeping as much support as possible for Gutenburg out of _s would be a bad idea. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment