Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Include "entry updated" as part of the hAtom. #131

Closed
mfields opened this Issue Jan 2, 2013 · 7 comments

Comments

Projects
None yet
5 participants
Contributor

mfields commented Jan 2, 2013

We currently do not provide an "entry updated" element which causes the following error in Google's Structured Data Testing Tool:

Google Error

I think that it would be a good idea to add this element to conform with hAtom Microformat:
http://microformats.org/wiki/hatom#Entry_Updated

Not sure the best way to go about this though ... any thoughts on how to best insert an element that is not meant to be displayed?

Member

obenland commented Jan 3, 2013

In The Bootstrap I gave it the assistive-text class: https://github.com/obenland/the-bootstrap/blob/2.1.0/inc/template-tags.php#L94

It's ugly, but it works.

Contributor

satrya commented Jan 12, 2013

+1 for @obenland , you can add the class updated to the class="entry-date"

Contributor

mfields commented Jan 21, 2013

What do you think about display: none;? I'm not sure that assistive-text would be best because that class is designated for text that should be hidden visually but read by assistive technologies. Here, I think we would want to always hide the text visually and audibly but expose it to data scrapers.

Member

obenland commented Jan 21, 2013

I agree

@philiparthurmoore philiparthurmoore pushed a commit that referenced this issue Feb 28, 2013

Philip Arthur Moore Let us try this one more time. Revert all changes made to _s up until…
… commit debefa merge until #131 has had a proper code review.
c8c60b3

@philiparthurmoore philiparthurmoore pushed a commit that referenced this issue Feb 28, 2013

Philip Arthur Moore Manually revert all changes made after debefa8 so that the code propo…
…sed in #131 gets a proper review.
dcd62e3
Collaborator

philiparthurmoore commented Feb 28, 2013

The above three commits are what happens when you try to roll back a repository the wrong way. The repo has been reverted to the state it was in at commit debefa8. Code review needs to be done on commit 4a8ffa299a4a7a1a171646b3af2c6662e0d516f7, by @michiecat, which doesn't show up in the repo history anymore (my fault/doing). Ignore the above three commits for any code review work. @michiecat, if you submit a patch from a fork on your account it'd be easy to merge into _s after review. How does that sound?

Contributor

michiecat commented Feb 28, 2013

Thanks @philiparthurmoore for committing/then reverting above. I had erroneously committed my code for this issue, when I intended to submit a pull request so that it can be properly reviewed.

In Pull Request #170, I followed @obenland's Bootstrap example. The .updated class gets a display: none as well.

Member

obenland commented Jun 26, 2013

Close in favor of #170.

@obenland obenland closed this Jun 26, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment