different font sizes #160

Closed
dollseb opened this Issue Feb 21, 2013 · 9 comments

Comments

Projects
None yet
4 participants

dollseb commented Feb 21, 2013

style.css

line 235: font-size: 12px;
line 236: font-size: 1.4rem;

line 235 is a fallback for browsers that don't support rem.

Collaborator

philiparthurmoore commented Feb 22, 2013

line 235 is a fallback for browsers that don't support rem.

Yep. Closing.

Member

obenland commented Feb 22, 2013

Base font is 10px, so 1.4rem translates to 14px. Should be either 1.2rem or 14px.

@obenland obenland reopened this Feb 22, 2013

Collaborator

philiparthurmoore commented Feb 22, 2013

D'oh. Too quick on the draw. Apologies, fine sir.

Collaborator

philiparthurmoore commented Feb 22, 2013

1.4 rem:

1.4 rem

12px:

12px

I feel like this should be 1.2rem instead of 1.4rem.

Member

obenland commented Feb 22, 2013

I fell like we should decrease padding! :D

Collaborator

philiparthurmoore commented Feb 22, 2013

I fell like we should decrease padding!

Along with reducing the rem or keeping the rem the same and reducing the padding so that it doesn't look so funky?

Reduced padding to padding: .5em .75em; on button, html input[type="button"], input[type="reset"], input[type="submit"] with 1.4rem:

GitHub Logo

Reduced padding to padding: .75em 1em; with 1.2rem:

GitHub Logo

These are very arbitrary padding values I've chosen just to show the differences on font sizing with reduced padding.

I definitely think we should lower the font size.

Member

obenland commented Feb 23, 2013

I agree

Collaborator

philiparthurmoore commented Feb 23, 2013

Closing this and moving the padding discussion over to #161.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment