The class .updated conflicts with _s for the events calendar #428

Closed
vijayrajesh opened this Issue Mar 6, 2014 · 6 comments

Projects

None yet

4 participants

@vijayrajesh

Hi,

First, I would like to tell you guys rock. Awesome base theme. I am starting each theme with _s only

BTW, recently I had to use "the events calendar" plugin with my_s based theme. But while using it, the 'date' fields were all hidden. While debugging I found that _s sets "display:none;" for the .updated class.

In my personal opinion, ".updated" is very common word in classes. May i suggest you could use any prefix for the ".updated' class? I am just suggesting.

Moreover, I thought this post can help other people too while googling the events post calendar and _s (underscores) theme.

Thank you,

@obenland
Member
obenland commented Mar 6, 2014

We introduced .updated in 39d8f7a, as the last step to fully support the hAtom microformat. See #131 and #170.

It's a tough one because .updated is indeed a very generic class name, but I think in this instance it is not as much _s being in conflict with the events calendar plugin, as much as it is the plugin being in conflict with hAtom.

Have you brought the issue to their attention as well?

@vijayrajesh

Yes, I have notified them on the issue.

Yes, I agree with your point. The plugin does need to do something.

Thank you,

@vijayrajesh vijayrajesh closed this Mar 6, 2014
@obenland
Member
obenland commented Mar 6, 2014

Is there a public thread about that? I'm happy to chime in too.

@ckpicker

@obenland The .updated class is used consistently in WordPress core CSS for the admin.

@vijayrajesh Are you referring to conflicts on the front-end or back-end? The Events Calendar does not have any 'display:none;' rules for the .updated class that I can find. Could you be a bit more specific?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment