BUG? _s theme menu not displayed at all in Opera Mini #87

Closed
mppm opened this Issue Sep 24, 2012 · 3 comments

Comments

Projects
None yet
3 participants
@mppm

mppm commented Sep 24, 2012

Hi,

I tested the unchanged _s theme and I love it. But on my cell with Opera Mini and then online in Opera's Opera Mini Simulator [ http://www.opera.com/developer/tools/mini/ ] the top (main) menu is not displayed at all.

Then I deactivate the CSS by renaming the style.css and the menu finally shows up. I also checked the thematic and toolbox themes w/ the simulator and my cell. Both showed the menu. Any help is very well appreciated.

@ashfame

This comment has been minimized.

Show comment
Hide comment
@ashfame

ashfame Sep 24, 2012

Contributor

It gets hidden by default on smaller screens and becomes visible when menu text is clicked. This JS file is in action here - https://github.com/Automattic/_s/blob/master/js/small-menu.js

Contributor

ashfame commented Sep 24, 2012

It gets hidden by default on smaller screens and becomes visible when menu text is clicked. This JS file is in action here - https://github.com/Automattic/_s/blob/master/js/small-menu.js

@mppm

This comment has been minimized.

Show comment
Hide comment
@mppm

mppm Sep 24, 2012

Thanks Ashfame!

Now I see the problem. I changed the h1 headline ( In the header.php) to an h2 since I wanted only one h1 for better structure. But obviously the JS needed the h1 to work properly, because no "menu" became visible until I changed it back to a h1 headline again.

May I suggest it would be pretty useful, if the h1 tag actually is really a link and not just a headline. Admittedly I don't know if mobile users with a visual impairment and therefore using a screenreader can identify the h1 as a link?

Best regards.

mppm commented Sep 24, 2012

Thanks Ashfame!

Now I see the problem. I changed the h1 headline ( In the header.php) to an h2 since I wanted only one h1 for better structure. But obviously the JS needed the h1 to work properly, because no "menu" became visible until I changed it back to a h1 headline again.

May I suggest it would be pretty useful, if the h1 tag actually is really a link and not just a headline. Admittedly I don't know if mobile users with a visual impairment and therefore using a screenreader can identify the h1 as a link?

Best regards.

@mfields

This comment has been minimized.

Show comment
Hide comment
@mfields

mfields Nov 28, 2012

Contributor

I think that changing the h1 tag to an anchor would be inappropriate. In HTML 5 the nav element represents sectioning content and should contain heading content like an h1 tag.

Reference:

I'm going to close this ticket as wontfix Please see the following conversation for a few more reasons why: #66 (comment)

Contributor

mfields commented Nov 28, 2012

I think that changing the h1 tag to an anchor would be inappropriate. In HTML 5 the nav element represents sectioning content and should contain heading content like an h1 tag.

Reference:

I'm going to close this ticket as wontfix Please see the following conversation for a few more reasons why: #66 (comment)

@mfields mfields closed this Nov 28, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment