Change primary menu idea to menu-1 #1018

merged 1 commit into from Dec 23, 2016


None yet

3 participants

mrwweb commented Sep 16, 2016

This makes _s align with the new Theme User Experience Requirements. The logic seems quite solid on its own:

Menu IDs should take the format of menu-1, menu-2, etc. Reason: Consistency across themes means that a user can switch themes and not have to reassign their menu to the theme’s menu location. It also allows easier readability in code.

There's no reason not to make _s themes as portable as possible, and this encourages an easy-to-infer naming scheme.

@karmatosed karmatosed merged commit 9700947 into Automattic:master Dec 23, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
@karmatosed karmatosed referenced this pull request in Automattic/theme-components Dec 23, 2016

Change primary menu idea to menu-1 #319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment