Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Infinite Scroll support #107

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
5 participants
@ethitter
Copy link

commented Nov 9, 2012

Adds the most basic support for Infinite Scroll, with a link to the support doc for users to expand on it.

Fixes #105.

@mfields

This comment has been minimized.

Copy link
Contributor

commented Jan 18, 2013

I think that overall this is a really good idea. I think that the code should be included in a file named jetpack.compat.php that lives inside inc/ - this file should be included in functions.php and be commented out by default. What does everyone else think?

@philiparthurmoore

This comment has been minimized.

Copy link
Collaborator

commented Jan 18, 2013

What does everyone else think?

Sounds like a good plan to me.

@ianstewart

This comment has been minimized.

Copy link
Contributor

commented Jan 18, 2013

+1 to a Jetpack file in includes. /inc/jetpack.php ?

@philiparthurmoore

This comment has been minimized.

Copy link
Collaborator

commented Jan 18, 2013

/inc/jetpack.php ?

We use jetpack.compat.php for all the files on WP.com, so I'd prefer to follow that convention or change the way we name it on .com to follow suit.

@obenland

This comment has been minimized.

Copy link
Member

commented Jan 18, 2013

Yes!

@mfields

This comment has been minimized.

Copy link
Contributor

commented Jan 19, 2013

I'm not sure why we use jetpack.compat.php - I was just following an already established convention. Would jetpack.php be better? I kinda like it.

@philiparthurmoore

This comment has been minimized.

Copy link
Collaborator

commented Jan 19, 2013

I'm not sure why we use jetpack.compat.php - I was just following an already established convention. Would jetpack.php be better? I kinda like it.

I like it, too. :)

@ethitter

This comment has been minimized.

Copy link
Author

commented Jan 20, 2013

If we're in agreement, I'll make these changes.

For the record, it sounds like a fine idea to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.