Basic Infinite Scroll support #107

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
5 participants

ethitter commented Nov 9, 2012

Adds the most basic support for Infinite Scroll, with a link to the support doc for users to expand on it.

Fixes #105.

Contributor

mfields commented Jan 18, 2013

I think that overall this is a really good idea. I think that the code should be included in a file named jetpack.compat.php that lives inside inc/ - this file should be included in functions.php and be commented out by default. What does everyone else think?

Collaborator

philiparthurmoore commented Jan 18, 2013

What does everyone else think?

Sounds like a good plan to me.

Contributor

ianstewart commented Jan 18, 2013

+1 to a Jetpack file in includes. /inc/jetpack.php ?

Collaborator

philiparthurmoore commented Jan 18, 2013

/inc/jetpack.php ?

We use jetpack.compat.php for all the files on WP.com, so I'd prefer to follow that convention or change the way we name it on .com to follow suit.

Member

obenland commented Jan 18, 2013

Yes!

Contributor

mfields commented Jan 19, 2013

I'm not sure why we use jetpack.compat.php - I was just following an already established convention. Would jetpack.php be better? I kinda like it.

Collaborator

philiparthurmoore commented Jan 19, 2013

I'm not sure why we use jetpack.compat.php - I was just following an already established convention. Would jetpack.php be better? I kinda like it.

I like it, too. :)

If we're in agreement, I'll make these changes.

For the record, it sounds like a fine idea to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment