Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Use the section tag for #primary divs across all template files. #117

Closed
wants to merge 1 commit into from

4 participants

@kovshenin
Owner

I don't see a reason to use div for some places and section for other places for the same #primary block. Is it because sections need titles? Why don't we use section everywhere instead? Consistent with search.php and archive.php.

@ianstewart
Owner

It's the titles. I'm curious about the benefit that would come from moving to divs. CSS can and should target the class name in this case anyway so element consistency in this case wouldn't be a gain for that.

@satrya

+1

@sixhours
Owner

Let's consolidate discussion into #104

@sixhours sixhours closed this
This was referenced
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 6, 2012
  1. @kovshenin

    Use the section tag for #primary divs across all template files. Cons…

    kovshenin authored
    …istent with search.php and archive.php.
This page is out of date. Refresh to see the latest.
Showing with 10 additions and 10 deletions.
  1. +2 −2 404.php
  2. +2 −2 image.php
  3. +2 −2 index.php
  4. +2 −2 page.php
  5. +2 −2 single.php
View
4 404.php
@@ -8,7 +8,7 @@
get_header(); ?>
- <div id="primary" class="content-area">
+ <section id="primary" class="content-area">
<div id="content" class="site-content" role="main">
<article id="post-0" class="post error404 not-found">
@@ -42,6 +42,6 @@
</article><!-- #post-0 .post .error404 .not-found -->
</div><!-- #content .site-content -->
- </div><!-- #primary .content-area -->
+ </section><!-- #primary .content-area -->
<?php get_footer(); ?>
View
4 image.php
@@ -9,7 +9,7 @@
get_header();
?>
- <div id="primary" class="content-area image-attachment">
+ <section id="primary" class="content-area image-attachment">
<div id="content" class="site-content" role="main">
<?php while ( have_posts() ) : the_post(); ?>
@@ -106,6 +106,6 @@
<?php endwhile; // end of the loop. ?>
</div><!-- #content .site-content -->
- </div><!-- #primary .content-area .image-attachment -->
+ </section><!-- #primary .content-area .image-attachment -->
<?php get_footer(); ?>
View
4 index.php
@@ -14,7 +14,7 @@
get_header(); ?>
- <div id="primary" class="content-area">
+ <section id="primary" class="content-area">
<div id="content" class="site-content" role="main">
<?php if ( have_posts() ) : ?>
@@ -43,7 +43,7 @@
<?php endif; ?>
</div><!-- #content .site-content -->
- </div><!-- #primary .content-area -->
+ </section><!-- #primary .content-area -->
<?php get_sidebar(); ?>
<?php get_footer(); ?>
View
4 page.php
@@ -13,7 +13,7 @@
get_header(); ?>
- <div id="primary" class="content-area">
+ <section id="primary" class="content-area">
<div id="content" class="site-content" role="main">
<?php while ( have_posts() ) : the_post(); ?>
@@ -25,7 +25,7 @@
<?php endwhile; // end of the loop. ?>
</div><!-- #content .site-content -->
- </div><!-- #primary .content-area -->
+ </section><!-- #primary .content-area -->
<?php get_sidebar(); ?>
<?php get_footer(); ?>
View
4 single.php
@@ -8,7 +8,7 @@
get_header(); ?>
- <div id="primary" class="content-area">
+ <section id="primary" class="content-area">
<div id="content" class="site-content" role="main">
<?php while ( have_posts() ) : the_post(); ?>
@@ -28,7 +28,7 @@
<?php endwhile; // end of the loop. ?>
</div><!-- #content .site-content -->
- </div><!-- #primary .content-area -->
+ </section><!-- #primary .content-area -->
<?php get_sidebar(); ?>
<?php get_footer(); ?>
Something went wrong with that request. Please try again.