Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Enable coding standards for JS files #1187

Closed
wants to merge 1 commit into from

Conversation

grappler
Copy link
Collaborator

When discussing in #1153 about activating PHPCS for JavaScript files we realized that there were a few issues to be fixed. This PR does that.

We should merge #1140 and #1153 before this.

@grappler grappler changed the title Enable coding standards for JS files WIP: Enable coding standards for JS files Jul 26, 2017
@grappler
Copy link
Collaborator Author

The travis tests are now failing for jshint and jscs at the moment. I would like to run the JS files through ESLint before I update the code again. I am waiting for v3.0 of eslint-config-wordpress to be released before I run it.

@grappler
Copy link
Collaborator Author

@ntwb Do you have an idea when v3.0 of eslint-config-wordpress will be released? I am happy to help with testing.

@Ismail-elkorchi
Copy link
Contributor

Closing as coding standards for JS files were enabled in #1386 and fixed in #1388

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants