New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Skip to content" link changes visual focus, but not input focus #136

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@HTMLbyJoe

HTMLbyJoe commented Jan 15, 2013

The problem is that when someone clicks a skip link, the viewport is scrolled to the #content, but pressing tab will bring focus to the site's main navigation. The expected behavior would be to select the first link in the #content, not the site's main navigation. Of course this is the browser's default behavior, and not really a _s bug, but it is an opportunity to make _s-based themes more accessible to users that navigate solely through keyboard input.

I learned about this issue via an article written by Nicholas C. Zakas. He suggests setting focus to the #content using JavaScript. I've adapted his example to use jQuery and to better conform to WordPress coding standards.

@mfields

This comment has been minimized.

Contributor

mfields commented Feb 2, 2013

@aaronjorbin Thanks for taking a look at this.

The javascript seems to work pretty well. I ran some tests and it appears that its inclusion is presently blocked by #148. We should revisit after that issue is resolved.

@mfields

This comment has been minimized.

Contributor

mfields commented Feb 27, 2013

Closing this because it was fixed when #139 was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment