Remove vendor prefixes on box-shadow. #176

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

JamesGeiger commented Mar 13, 2013

Not needed except in rare cases where the user has an extremely outdated version of iOS safari.

JamesGeiger reopened this Mar 13, 2013

Member

obenland commented Mar 13, 2013

For the record, -webkit-box-shadow is still required for Blackberry.
I'm in favor of making the change though.

Contributor

JamesGeiger commented Mar 14, 2013

I saw that it was still required for Blackberry (on caniuse.com), but is it worth keeping it in just for that?

I don't think there is much reason to keep the prefix just for Blackberry (especially with them having a near future version out). -moz- should definitely go though. Though you should revert your second commit since that does more than just remove the vendor prefixes.

Contributor

JamesGeiger commented Mar 14, 2013

I thought we may as will kill the lines of code that support IE 6/7 though, since they are extremely out of date browsers (IE7 was released 6 years ago).

I completely agree, but the pull request is titled "Remove vendor prefixes on box-shadow". I'd recommend opening a new pull request/issue for IE6/7 support so there can be discussion there.

Contributor

JamesGeiger commented Mar 15, 2013

@andrewryno You are right. How do I remove that commit from this pull request?

obenland closed this in 4c12083 Mar 26, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment