Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Image navigation improvements #178

Closed
wants to merge 12 commits into
from

Conversation

Projects
None yet
5 participants
Member

eduardozulian commented Mar 15, 2013

Add a navigation role, replace spans with divs and also add a '.meta-nav' for both previous and next image links.

Image navigation improvements
Add a navigation role, replace spans with divs and also add a
'.meta-nav' for both previous and next image links.
Member

obenland commented Mar 15, 2013

@eduardozulian Would you mind updating your repo with the lates changes? It would help us tremendously in getting your pull request in quickly.

Thanks!

Collaborator

grappler commented Mar 16, 2013

Do the the navigation arrows need to be translated? If not then you could take them out so that only "Previous" and "Next" can be translated.

obenland and others added some commits Mar 4, 2013

_s: Enable live preview for Header Text Color in Customizer. Change also
removes an !important declaration in Custom Header CSS rules.
_s: Formatting changes:
- Reduce element comments to either the element id or the first element
class.
- Tabs > Spaces.
- Improve adherence to formatting guidelines.
_s: Introduce a default for clearing floats.
Selectors provide clearing out of the box for the site container,
header, footer, main container, content container, entry content, and
comment content.

Also, theme developers can optionally use .clear as a utility class. Or
delete it.

For more information about the philosophy behind the approach of
selecting class elements, see
http://24ways.org/2012/a-harder-working-class/

Fixes #88.
Add an identifier into style.css that will allow us — the WordPress.c…
…om Theme Team — to easily search for themes that have been built with _s. Now there will be no more scratching our heads whenever someone asks, "What have you built with _s?" :)
_s: Use .screen-reader-text rather than .assistive-text.
With 3.6 introducing many HTML5 improvements the need for custom
searchform and comment templates will vanish. To cope with core's
.screen-reader-text class, let's make the switch early.

Commit also adds core's focus styles for screen reader texts, so they
can actually be used.
Image navigation improvements
Add a navigation role, replace spans with divs and also add a
'.meta-nav' for both previous and next image links.

@eduardozulian eduardozulian deleted the eduardozulian:patch/image-navigation branch Mar 16, 2013

Member

obenland commented Mar 16, 2013

Do the the navigation arrows need to be translated? If not then you could take them out so that only "Previous" and "Next" can be translated.

Yes, they should be translatable so RTL languages can change their position.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment