Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Ditch all @since DocBlocks from theme. #182

Merged
merged 1 commit into from Mar 18, 2013

Conversation

Projects
None yet
3 participants
Collaborator

philiparthurmoore commented Mar 18, 2013

@SInCE as a DocBlock in _s doesn't make much sense and should be removed entirely from the theme. Reasons:

  1. The DocBlock makes it hard to retrofit old themes to _s without going through the trouble of manually ditching each @SInCE DocBlock
  2. In practice new functions rarely, if ever, get added into the themes we're developing using _s and @SInCE feels like unnecessary clutter.
  3. @SInCE _s 1.0 is unique to _s itself, and doesn't make sense in context with other themes. For example, '@SInCE _s 1.2' in the Customizer makes sense for _s but when a new theme is spun off using _s, that version number loses meaning and needs a new version number for the theme that's being developed.
  4. I'd prefer to look at _s as a non-versioned theme that keeps getting rolling updates to its V. 1.0.

I'm certain there are other good reasons to gut this, but my brain is failing me at the moment. I think the above three are more than adequate.

Contributor

mfields commented Mar 18, 2013

+1 - Point number 3 Makes the most sense to me.

Member

obenland commented Mar 18, 2013

Do it!

philiparthurmoore pushed a commit that referenced this pull request Mar 18, 2013

@philiparthurmoore philiparthurmoore merged commit 84ed9c5 into Automattic:master Mar 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment