Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Update header.php #190

Closed
wants to merge 1 commit into from

2 participants

Leo Gono Konstantin Obenland
Leo Gono

Toggle Nav ID and Class. site-navigation should be used as class while navigation-main should be ID.

Leo Gono leogono Update header.php
Toggle Nav ID and Class. site-navigation should be used as class while navigation-main should be ID.
a123102
Konstantin Obenland
Owner

Could you elaborate on that? We recently did a big change on that in fa3d869

Leo Gono

It's not really a big thing. I think site-navigation term is more suited than navigation-main as it's class. navigation-main can be the ID and site-navigation be the class. I also understand that this will need changes on the css as well. I actually changed it that way on my local copy. But the theme as is, is pretty great. It's just the term and does not affect any theme functionality.

Konstantin Obenland
Owner

If it's a personal preference, would you mind if we'd close it then?
_s is meant to be a starting point, not an end-to-end solution for all use cases.

Leo Gono leogono closed this
Leo Gono leogono deleted the branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 21, 2013
  1. Leo Gono

    Update header.php

    leogono authored
    Toggle Nav ID and Class. site-navigation should be used as class while navigation-main should be ID.
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  header.php
2  header.php
View
@@ -30,7 +30,7 @@
<h2 class="site-description"><?php bloginfo( 'description' ); ?></h2>
</hgroup>
- <nav id="site-navigation" class="navigation-main" role="navigation">
+ <nav id="navigation-main" class="site-navigation" role="navigation">
<h1 class="menu-toggle"><?php _e( 'Menu', '_s' ); ?></h1>
<div class="screen-reader-text skip-link"><a href="#content" title="<?php esc_attr_e( 'Skip to content', '_s' ); ?>"><?php _e( 'Skip to content', '_s' ); ?></a></div>
Something went wrong with that request. Please try again.