Update header.php #190

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@leogono

Toggle Nav ID and Class. site-navigation should be used as class while navigation-main should be ID.

@leogono leogono Update header.php
Toggle Nav ID and Class. site-navigation should be used as class while navigation-main should be ID.
a123102
@obenland
Automattic member

Could you elaborate on that? We recently did a big change on that in fa3d869

@leogono

It's not really a big thing. I think site-navigation term is more suited than navigation-main as it's class. navigation-main can be the ID and site-navigation be the class. I also understand that this will need changes on the css as well. I actually changed it that way on my local copy. But the theme as is, is pretty great. It's just the term and does not affect any theme functionality.

@obenland
Automattic member

If it's a personal preference, would you mind if we'd close it then?
_s is meant to be a starting point, not an end-to-end solution for all use cases.

@leogono leogono closed this Mar 27, 2013
@leogono leogono deleted the unknown repository branch Mar 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment