Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Add missing 'class' comments #20

Merged
merged 1 commit into from

3 participants

@obenland
Owner

I haven't sent a pull request in 2 months, so I thought it would be time for another one.

Adding missing class comments is vital - in my opinion - for the future of _s.

Okay, maybe it is not THAT important, but I'm German and I like it clean! :)

@LimeBlast

This looks good to me - pull it in :)

@lancewillett lancewillett merged commit 64f1d1a into Automattic:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on May 23, 2012
  1. @obenland

    Add missing 'class' comments

    obenland authored
This page is out of date. Refresh to see the latest.
View
6 404.php
@@ -14,7 +14,7 @@
<article id="post-0" class="post error404 not-found">
<header class="entry-header">
<h1 class="entry-title"><?php _e( 'Oops! That page can&rsquo;t be found.', '_s' ); ?></h1>
- </header>
+ </header><!-- .entry-header -->
<div class="entry-content">
<p><?php _e( 'It looks like nothing was found at this location. Maybe try one of the links below or a search?', '_s' ); ?></p>
@@ -28,7 +28,7 @@
<ul>
<?php wp_list_categories( array( 'orderby' => 'count', 'order' => 'DESC', 'show_count' => 1, 'title_li' => '', 'number' => 10 ) ); ?>
</ul>
- </div>
+ </div><!-- .widget -->
<?php
/* translators: %1$s: smilie */
@@ -39,7 +39,7 @@
<?php the_widget( 'WP_Widget_Tag_Cloud' ); ?>
</div><!-- .entry-content -->
- </article><!-- #post-0 -->
+ </article><!-- #post-0 .post .error404 .not-found -->
</div><!-- #content -->
</div><!-- #primary .site-content -->
View
2  archive.php
@@ -65,7 +65,7 @@
echo apply_filters( 'tag_archive_meta', '<div class="taxonomy-description">' . $tag_description . '</div>' );
}
?>
- </header>
+ </header><!-- .page-header -->
<?php rewind_posts(); ?>
View
6 comments.php
@@ -39,7 +39,7 @@
<h1 class="assistive-text"><?php _e( 'Comment navigation', '_s' ); ?></h1>
<div class="nav-previous"><?php previous_comments_link( __( '&larr; Older Comments', '_s' ) ); ?></div>
<div class="nav-next"><?php next_comments_link( __( 'Newer Comments &rarr;', '_s' ) ); ?></div>
- </nav>
+ </nav><!-- #comment-nav-before .site-navigation .comment-navigation -->
<?php endif; // check for comment navigation ?>
<ol class="commentlist">
@@ -52,14 +52,14 @@
*/
wp_list_comments( array( 'callback' => '_s_comment' ) );
?>
- </ol>
+ </ol><!-- .commentlist -->
<?php if ( get_comment_pages_count() > 1 && get_option( 'page_comments' ) ) : // are there comments to navigate through ?>
<nav role="navigation" id="comment-nav-below" class="site-navigation comment-navigation">
<h1 class="assistive-text"><?php _e( 'Comment navigation', '_s' ); ?></h1>
<div class="nav-previous"><?php previous_comments_link( __( '&larr; Older Comments', '_s' ) ); ?></div>
<div class="nav-next"><?php next_comments_link( __( 'Newer Comments &rarr;', '_s' ) ); ?></div>
- </nav>
+ </nav><!-- #comment-nav-below .site-navigation .comment-navigation -->
<?php endif; // check for comment navigation ?>
<?php endif; // have_comments() ?>
View
2  content.php
@@ -57,5 +57,5 @@
<?php endif; ?>
<?php edit_post_link( __( 'Edit', '_s' ), '<span class="sep"> | </span><span class="edit-link">', '</span>' ); ?>
- </footer><!-- #entry-meta -->
+ </footer><!-- .entry-meta -->
</article><!-- #post-<?php the_ID(); ?> -->
View
2  header.php
@@ -56,7 +56,7 @@
<div class="assistive-text skip-link"><a href="#content" title="<?php esc_attr_e( 'Skip to content', '_s' ); ?>"><?php _e( 'Skip to content', '_s' ); ?></a></div>
<?php wp_nav_menu( array( 'theme_location' => 'primary' ) ); ?>
- </nav>
+ </nav><!-- .site-navigation .main-navigation -->
</header><!-- #masthead .site-header -->
<div id="main">
View
4 image.php
@@ -78,7 +78,7 @@
<?php if ( ! empty( $post->post_excerpt ) ) : ?>
<div class="entry-caption">
<?php the_excerpt(); ?>
- </div>
+ </div><!-- .entry-caption -->
<?php endif; ?>
</div><!-- .entry-attachment -->
@@ -106,6 +106,6 @@
<?php endwhile; // end of the loop. ?>
</div><!-- #content -->
- </div><!-- #primary .site-content -->
+ </div><!-- #primary .site-content .image-attachment -->
<?php get_footer(); ?>
View
2  no-results.php
@@ -31,4 +31,4 @@
<?php } ?>
</div><!-- .entry-content -->
-</article><!-- #post-0 -->
+</article><!-- #post-0 .post .no-results .not-found -->
View
2  search.php
@@ -15,7 +15,7 @@
<header class="page-header">
<h1 class="page-title"><?php printf( __( 'Search Results for: %s', '_s' ), '<span>' . get_search_query() . '</span>' ); ?></h1>
- </header>
+ </header><!-- .page-header -->
<?php _s_content_nav( 'nav-above' ); ?>
Something went wrong with that request. Please try again.