Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove title attributes #300

Merged
merged 3 commits into from Sep 25, 2013

Conversation

Projects
None yet
4 participants
@davidakennedy
Copy link
Member

commented Aug 24, 2013

This pull request removes title attributes from _s

While title attributes are grounded in good meaning, they are not very useful. They're used in many ways, but only helpful in a few situations.

In the case of _s, they're used to provide additional information on links. However, this information can only be accessed via tooltip by mouse users. Screen readers by default do not enunciate the title attribute, so the title attribute isn't useful in _s.

The WordPress Accessibility Team is working to remove title attributes from coreslated for 3.7 right now after some good discussion on it.

Let me know if there are any questions!

@obenland

This comment has been minimized.

Copy link
Member

commented Aug 26, 2013

Let's wait for http://core.trac.wordpress.org/attachment/ticket/25054/25054.titleattr.diff and if that gets into Twenty Fourteen, before we get this in.

@davidakennedy

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2013

Sounds good! Thanks, @obenland.

@obenland obenland merged commit 48ac0da into Automattic:master Sep 25, 2013

@obenland

This comment has been minimized.

Copy link
Member

commented Sep 25, 2013

Hm, sometimes I don't understand GitHub. Even though I merged the changes from @davidakennedy's repo, he does not get props for the commits I merged. Odd. :(

@davidakennedy

This comment has been minimized.

Copy link
Member Author

commented Sep 26, 2013

Oh man. Bummer! :( This was my first contribution, and I was pumped to see my face on the Underscores site. But I'm glad I could help out. :)

I figured out why I didn't get credit for my commit. I didn't have my email linked to my Github account. Do now!

Thanks for merging!

@vinoddalvi

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2013

I am facing the same problem with GitHub. I have contributed to this repo but didn't get props.
I have my email linked to my Github account.
I think the problem is it's taking my name "Vinod Dalvi" in commits instead of my user name "vinodvdalvi" but don't know why it's taking my name "Vinod Dalvi" in commits?

@sheabunge

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2013

@vinodvdalvi You need to make sure you add the email you use with Git on your computer to your GitHub account

@vinoddalvi

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2013

@bungeshea Thanks for reply. Yes i am sure that i have added the email i use with Git on my computer to my GitHub account

@vinoddalvi

This comment has been minimized.

Copy link
Contributor

commented Sep 29, 2013

Resolved the GitHub contribution problem, it i was occurring because i was committing code from netbeans.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.