Fixed the order of text replacements #387

Merged
merged 1 commit into from Feb 25, 2014

4 participants

@aahan

Proper order is necessary to do the intended text replacements.

@aahan aahan Fixed the order of text replacements
Proper order is necessary to do the intended text replacements.
45b985d
@sheabunge

👍 It does appear that searching for  _s (with a space before it) will also pick up the textdomain deceleration in style.css.

@aahan aahan closed this Jan 22, 2014
@aahan aahan reopened this Jan 22, 2014
@obenland

Can you clarify on what exactly is not working or going wrong with the current order?

@sheabunge

@obenland If you are replacing DocBlocks by searching for  _s (with a space before it), the search will also capture Text Domain: _s in style.css, resulting in Textdomain: DocBlockName instead of the expected Textdomain: textdomain-handle.

This is why the order should be changed; so the style.css textdomain header is updated before the DocBlock search takes place.

@ihorvorotnov

Noticed the same issue yesterday, when starting a new project. Changing order helps.

@aahan aahan closed this Feb 24, 2014
@aahan aahan reopened this Feb 24, 2014
@obenland obenland merged commit 1e6e4d8 into Automattic:master Feb 25, 2014
@aahan aahan deleted the unknown repository branch Feb 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment