Add entry-footer class to footer elements in an entry. #424

Merged
merged 2 commits into from Mar 6, 2014

Projects

None yet

2 participants

@matthewsimo
Contributor

Add the entry footer class, as brought up in issue #420. Went ahead and added this to the content-page and content.php templates as well, to keep consistency.

@obenland
Member
obenland commented Mar 3, 2014

Thanks for the PR!

Some feedback:
I think it's fine to just use .entry-footer and have it replace .entry-meta on the footer elements.
We also try to only reference the first class (only trumped by an id) in the closing element's comment to avoid clutter.

@matthewsimo
Contributor

Sure thing, wasn't sure since entry-meta was used in other places besides on the footer element inside entries. Also, wasn't sure of stance on back compatibility.

I'll make those edits, stand by.

@obenland obenland merged commit e3714be into Automattic:master Mar 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment