Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Revert "Merge pull request #36 from kovshenin/patch-5" #64

Merged
merged 1 commit into from

2 participants

@kovshenin
Owner

Howdy! I'd like to revert the change committed in #36. I think that the proposed change looked cleaner and more elegant, and seemed more correct (to me.) However, a similar patch proposed in Twenty Twelve was declined. I'd rather have the _s codebase look similar to the default themes, so that it's less confusing for developers to get started, and more in line with the core best practices.

Apologies for the caused trouble!

This reverts commit 800b9eb, reversing changes made to ce4bef6.

@kovshenin kovshenin Revert "Merge pull request #36 from kovshenin/patch-5"
This reverts commit 800b9ebcd1784bfb60b0e2887805911c19688418, reversing
changes made to ce4bef6129b42306e2446be5a665639e92f9ca0e.
461976d
@mfields

After reading through the core discussions and chatting with @kovshenin it seems like the best thing to do is revert 800b9eb.

@mfields mfields merged commit 7fef5cd into Automattic:master
@marksantiago marksantiago referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 31, 2012
  1. @kovshenin

    Revert "Merge pull request #36 from kovshenin/patch-5"

    kovshenin authored
    This reverts commit 800b9ebcd1784bfb60b0e2887805911c19688418, reversing
    changes made to ce4bef6129b42306e2446be5a665639e92f9ca0e.
This page is out of date. Refresh to see the latest.
Showing with 10 additions and 3 deletions.
  1. +10 −3 archive.php
View
13 archive.php
@@ -25,9 +25,16 @@
printf( __( 'Tag Archives: %s', '_s' ), '<span>' . single_tag_title( '', false ) . '</span>' );
} elseif ( is_author() ) {
- // Get the queried author data.
- $author = get_queried_object();
- printf( __( 'Author Archives: %s', '_s' ), '<span class="vcard"><a class="url fn n" href="' . esc_url( get_author_posts_url( $author->ID ) ) . '" title="' . esc_attr( $author->display_name ) . '" rel="me">' . esc_html( $author->display_name ) . '</a></span>' );
+ /* Queue the first post, that way we know
+ * what author we're dealing with (if that is the case).
+ */
+ the_post();
+ printf( __( 'Author Archives: %s', '_s' ), '<span class="vcard"><a class="url fn n" href="' . get_author_posts_url( get_the_author_meta( "ID" ) ) . '" title="' . esc_attr( get_the_author() ) . '" rel="me">' . get_the_author() . '</a></span>' );
+ /* Since we called the_post() above, we need to
+ * rewind the loop back to the beginning that way
+ * we can run the loop properly, in full.
+ */
+ rewind_posts();
} elseif ( is_day() ) {
printf( __( 'Daily Archives: %s', '_s' ), '<span>' . get_the_date() . '</span>' );
Something went wrong with that request. Please try again.