Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Revert "Merge pull request #36 from kovshenin/patch-5" #64

Merged
merged 1 commit into from Aug 31, 2012

Conversation

Projects
None yet
2 participants
Contributor

kovshenin commented Aug 31, 2012

Howdy! I'd like to revert the change committed in #36. I think that the proposed change looked cleaner and more elegant, and seemed more correct (to me.) However, a similar patch proposed in Twenty Twelve was declined. I'd rather have the _s codebase look similar to the default themes, so that it's less confusing for developers to get started, and more in line with the core best practices.

Apologies for the caused trouble!

This reverts commit 800b9eb, reversing changes made to ce4bef6.

@kovshenin kovshenin Revert "Merge pull request #36 from kovshenin/patch-5"
This reverts commit 800b9eb, reversing
changes made to ce4bef6.
461976d
Contributor

mfields commented Aug 31, 2012

After reading through the core discussions and chatting with @kovshenin it seems like the best thing to do is revert 800b9eb.

@mfields mfields added a commit that referenced this pull request Aug 31, 2012

@mfields mfields Merge pull request #64 from kovshenin/patch-7
Revert "Merge pull request #36 from kovshenin/patch-5" This will better match core practices for default themes as well as restore functionality of the 'the_author' filter. props @kovshenin
7fef5cd

@mfields mfields merged commit 7fef5cd into Automattic:master Aug 31, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment