Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a languages directory and a readme file to help get started with translations #73

Merged
merged 1 commit into from Sep 13, 2012

Conversation

Projects
None yet
3 participants
@kovshenin
Copy link
Contributor

commented Sep 5, 2012

The title says it all. Props @pixolin

@kovshenin kovshenin referenced this pull request Sep 5, 2012

Closed

French translations #50

ianstewart added a commit that referenced this pull request Sep 13, 2012

Merge pull request #73 from kovshenin/patch-10
Add a languages directory and a readme file to help get started with translations

@ianstewart ianstewart merged commit 5746881 into Automattic:master Sep 13, 2012

@pixolin

This comment has been minimized.

Copy link
Contributor

commented on 1be531d Sep 16, 2012

For me it is still somewhat confusing that line 55 of functions.php points to a nonexisting textdomain /languages while the added readme.txt with the hints for adding your own translation is placed in /translations. Also, since development of the twentysomething themes it has become good practice to have a subdirectory languages for that purpose.

@kovshenin

This comment has been minimized.

Copy link
Contributor Author

commented Sep 17, 2012

Whoops! @pixolin not only is that confusing, but also incorrect. Addressed in #83. Sorry :)

mfields added a commit that referenced this pull request Oct 6, 2012

Merge pull request #83 from kovshenin/patch-12
Rename translations to languages, see #73 and #50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.