Skip to content

Corrected two typos #84

Merged
merged 1 commit into from Feb 3, 2013

4 participants

@pixolin
pixolin commented Sep 18, 2012

"don't" with ' should be more correct than &rsquot; (or is it better to escape it \' ?)

I personally find the line 

/* translators: %1$s: smiley */

pretty confusing, but at least it should be singular (not smilies)

(I'm not sure if I should have posted this under "Issues". I actually just started learning git to contribute to this project, so please excuse my ignorance.)

@pixolin pixolin Corrected two typos
"don't" with ' should be more correct than &rsquot; (or is it better to escape it \' ?)
I personally find the line * translators: %1$s: smiley */ pretty confusing, but at least it should be singular (not smilies)
13efab7
@philiparthurmoore

Seems like a perfectly sensible change to me.

@philiparthurmoore philiparthurmoore merged commit 9957c27 into Automattic:master Feb 3, 2013
@lancewillett
Automattic member
"don't" with ' should be more correct than &rsquot; (or is it better to escape it \' ?)

This change isn't correct — ’ is the correct entity for an apostrophe.

' is for a single "prime" quote — and we want the "right single curly quote" instead.

@philiparthurmoore

GitHub doesn't like your comment. :(

I recall having a discussion in person with Theme Team about this last week; seems everyone was fine with it, but you're making sense! So, back to (or adjust to) ’ instead?

@lancewillett
Automattic member

I fixed my comment. :)

I vote for ’ since it's a tiny bit more human-readable. We use it in default themes.

@philiparthurmoore philiparthurmoore pushed a commit that referenced this pull request Feb 12, 2013
Philip Arthur Moore Change apos back to the correct rsquo. See #84. e652d9f
@philiparthurmoore

@lancewillett: I changed it back and forgot to props you. I'm sorry. rsquo should be back in place, though.

@lancewillett
Automattic member

Fank you. Fank you very much.

@pixolin
pixolin commented Feb 13, 2013

OK, OK, I understand this topic is ridiculously unimportant …

Still don't understand though why a "right single quote" (’) is the better choice to mark an omission of a letter than an apostrophe (') which according to the definition in Wikipedia

In English, [it] serves three purposes:
* The marking of the omission of one or more letters (*as in the contraction of do not to don’t*). 
* […]

Anyway… For some reason I was credited on http://underscores.me for a contribution. Tell me, that's not for correcting a typo now, is it?! Too much honor…

Hope I can add a little more than that in the future and would be pleased to be mentioned then. Underscores is damn cool. Even with 'right single quotes' ;)

@ianstewart

There's a bit of naming confusion with the element and what it does. A correct apostrophe always looks like a right single quote. Or a "9" — check out the embarrassing first comment on that post! :)

@pixolin
pixolin commented Feb 13, 2013

Learning never stops.
Thanks for your answer!

(Well, and sorry for nitpicking … it just reminded me of the epic discussion I had with a former boss about differences of — (mdash), – (ndash) and hyphens. It's all about readability.)

@lancewillett
Automattic member

@pixolin If you haven't yet, read http://en.wikipedia.org/wiki/The_Elements_of_Typographic_Style -- it's the masterwork on typography and explains all the intricacies of correct usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.