Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Corrected two typos #84

Merged
merged 1 commit into from

4 participants

@pixolin

"don't" with ' should be more correct than &rsquot; (or is it better to escape it \' ?)

I personally find the line 

/* translators: %1$s: smiley */

pretty confusing, but at least it should be singular (not smilies)

(I'm not sure if I should have posted this under "Issues". I actually just started learning git to contribute to this project, so please excuse my ignorance.)

@pixolin pixolin Corrected two typos
"don't" with ' should be more correct than &rsquot; (or is it better to escape it \' ?)
I personally find the line * translators: %1$s: smiley */ pretty confusing, but at least it should be singular (not smilies)
13efab7
@philiparthurmoore
Collaborator

Seems like a perfectly sensible change to me.

@philiparthurmoore philiparthurmoore merged commit 9957c27 into from
@lancewillett
"don't" with ' should be more correct than &rsquot; (or is it better to escape it \' ?)

This change isn't correct — ’ is the correct entity for an apostrophe.

' is for a single "prime" quote — and we want the "right single curly quote" instead.

@philiparthurmoore
Collaborator

GitHub doesn't like your comment. :(

I recall having a discussion in person with Theme Team about this last week; seems everyone was fine with it, but you're making sense! So, back to (or adjust to) ’ instead?

@lancewillett

I fixed my comment. :)

I vote for ’ since it's a tiny bit more human-readable. We use it in default themes.

@philiparthurmoore philiparthurmoore referenced this pull request from a commit
Philip Arthur Moore Change apos back to the correct rsquo. See #84. e652d9f
@philiparthurmoore
Collaborator

@lancewillett: I changed it back and forgot to props you. I'm sorry. rsquo should be back in place, though.

@lancewillett

Fank you. Fank you very much.

@pixolin

OK, OK, I understand this topic is ridiculously unimportant …

Still don't understand though why a "right single quote" (’) is the better choice to mark an omission of a letter than an apostrophe (') which according to the definition in Wikipedia

In English, [it] serves three purposes:
* The marking of the omission of one or more letters (*as in the contraction of do not to don’t*). 
* […]

Anyway… For some reason I was credited on http://underscores.me for a contribution. Tell me, that's not for correcting a typo now, is it?! Too much honor…

Hope I can add a little more than that in the future and would be pleased to be mentioned then. Underscores is damn cool. Even with 'right single quotes' ;)

@ianstewart
Owner

There's a bit of naming confusion with the element and what it does. A correct apostrophe always looks like a right single quote. Or a "9" — check out the embarrassing first comment on that post! :)

@pixolin

Learning never stops.
Thanks for your answer!

(Well, and sorry for nitpicking … it just reminded me of the epic discussion I had with a former boss about differences of — (mdash), – (ndash) and hyphens. It's all about readability.)

@lancewillett

@pixolin If you haven't yet, read http://en.wikipedia.org/wiki/The_Elements_of_Typographic_Style -- it's the masterwork on typography and explains all the intricacies of correct usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Sep 18, 2012
  1. @pixolin

    Corrected two typos

    pixolin authored
    "don't" with ' should be more correct than &rsquot; (or is it better to escape it \' ?)
    I personally find the line * translators: %1$s: smiley */ pretty confusing, but at least it should be singular (not smilies)
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +2 −2 404.php
View
4 404.php
@@ -13,7 +13,7 @@
<article id="post-0" class="post error404 not-found">
<header class="entry-header">
- <h1 class="entry-title"><?php _e( 'Oops! That page can&rsquo;t be found.', '_s' ); ?></h1>
+ <h1 class="entry-title"><?php _e( 'Oops! That page can&apos;t be found.', '_s' ); ?></h1>
</header><!-- .entry-header -->
<div class="entry-content">
@@ -31,7 +31,7 @@
</div><!-- .widget -->
<?php
- /* translators: %1$s: smilie */
+ /* translators: %1$s: smiley */
$archive_content = '<p>' . sprintf( __( 'Try looking in the monthly archives. %1$s', '_s' ), convert_smilies( ':)' ) ) . '</p>';
the_widget( 'WP_Widget_Archives', 'dropdown=1', "after_title=</h2>$archive_content" );
?>
Something went wrong with that request. Please try again.