Minor Change: removed wp tag in html comment #85

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@pixolin
Contributor

pixolin commented Sep 19, 2012

The usage of a WordPress Tag within a html comment to identify a html end tag is a performance waste (needs to be rendered by PHP) and doesn't improve the readability of the code.
This applies to a couple of other templates, too.

Minor Change: removed wp tag in html comment
The usage of a WordPress Tag within a html comment to identify a html end tag is a performance waste (needs to be rendered by PHP) and doesn't improve the readability of the code.
This applies to a couple of other templates, too.
@ashfame

This comment has been minimized.

Show comment
Hide comment
@ashfame

ashfame Sep 19, 2012

Contributor

I disagree. The very minute performance gain here is very easily outweighed by the advantage of having markup being easy to read.

Contributor

ashfame commented Sep 19, 2012

I disagree. The very minute performance gain here is very easily outweighed by the advantage of having markup being easy to read.

@kovshenin

This comment has been minimized.

Show comment
Hide comment
@kovshenin

kovshenin Sep 19, 2012

Contributor

a html end tag is a performance waste (needs to be rendered by PHP)

The whole file needs to be parsed and rendered by PHP anyway, so the "extra" call to the_ID doesn't really decrease performance. I don't think it's more readable, or less readable, and I don't really see a point if it being there in the first place. I've never found a good use for it when reading markup, since Chrome's developer tools and Firebug would indent elements in a way where you can always see the corresponding closing tag.

In any case, if people do find it useful, I think we should leave it as is.

Contributor

kovshenin commented Sep 19, 2012

a html end tag is a performance waste (needs to be rendered by PHP)

The whole file needs to be parsed and rendered by PHP anyway, so the "extra" call to the_ID doesn't really decrease performance. I don't think it's more readable, or less readable, and I don't really see a point if it being there in the first place. I've never found a good use for it when reading markup, since Chrome's developer tools and Firebug would indent elements in a way where you can always see the corresponding closing tag.

In any case, if people do find it useful, I think we should leave it as is.

@ashfame

This comment has been minimized.

Show comment
Hide comment
@ashfame

ashfame Sep 19, 2012

Contributor

Yep! We all use tools that make the process of inspecting markup easier but think of "View source", some extra indication over there can't hurt IMO :)

Contributor

ashfame commented Sep 19, 2012

Yep! We all use tools that make the process of inspecting markup easier but think of "View source", some extra indication over there can't hurt IMO :)

@mfields

This comment has been minimized.

Show comment
Hide comment
@mfields

mfields Oct 6, 2012

Contributor

I agree @kovshenin here. While I personally do not find these tags useful, I'm sure there are many others that do. I think it is a good idea to keep them around to aid in debugging for developers of all skill levels.

Contributor

mfields commented Oct 6, 2012

I agree @kovshenin here. While I personally do not find these tags useful, I'm sure there are many others that do. I think it is a good idea to keep them around to aid in debugging for developers of all skill levels.

@mfields mfields closed this Oct 6, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment