Update the replace example in README.md #906

Merged
merged 2 commits into from Dec 23, 2016

Projects

None yet

6 participants

@ardalann
Contributor

Many might choose multiple words as theme name, and they may not be sure where they should use a space, a hyphen or an underscore to separate words when doing the initial replacements. The example provided in the README file should cover that scenario.

@ardalann ardalann Update the replace example in README.md
Many might choose multiple words as theme name, and they may not be sure where they should use a space, a hyphen or an underscore to separate words when doing the initial replacements. The example provided in the README file should cover that scenario.
6b215b6
@karmatosed
Member

I'm not sure this is something we should add. I haven't seen someone have an issue or not know they can do this. Have you?

@philiparthurmoore
Collaborator

I've run into this confusion multiple times.

On Mon, Feb 8, 2016 at 6:28 PM, Tammie Lister notifications@github.com
wrote:

I'm not sure this is something we should add. I haven't seen someone have
an issue or not know they can do this. Have you?


Reply to this email directly or view it on GitHub
#906 (comment).

@ardalann
Contributor
ardalann commented Feb 9, 2016

I've run into this issue many times. Whenever I wanted to use _s to develop a new theme, I had to find out where I should use a space, a hyphen or an underscore.

@sixhours
Contributor

I'm fine with this change, since it clarifies how to work with theme names that have spaces.

@sixhours sixhours removed the Suggest Close label Feb 26, 2016
@ianstewart
Contributor

The poor Megatherium just can't catch a break.

@sixhours
Contributor

We could change it to Megatherium Is Awesome ;)

@ianstewart
Contributor

@karmatosed
Member

I kind of like idea for prosperity and cute projectness it would be: megatherium-is-awesome

@philiparthurmoore
Collaborator

Let's get this in. It's a great change. Not at the computer at the moment but those Travis errors need to be looked at pre-merge.

@davidakennedy
Member

Hey @ardalann, this is old, but worthy issue to revive. I'd like to get it merged! Can you update your change with megatherium-is-awesome as suggested above? Thanks!

@ardalann
Contributor
ardalann commented Sep 4, 2016

Hey @davidakennedy, I just updated the example theme name.

@karmatosed karmatosed merged commit 8c6cffc into Automattic:master Dec 23, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment